You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We should refactor the charm to be configured using a simple yaml file instead of generating it using the envoy_data_plane package for the following reasons.
In general, it is a more cumbersome developer experience to map changes in the envoy.yaml file to the correspond. In other words, it's easier to just copy changes from upstream if we also use a yaml file.
This has caused us trouble in the past e.g. in this PR fix: Update envoy configuration #64 (comment) we had to revert changes because the python package didn't work the same way with the yaml file (see bullet about revert max_grpc_timeout). This also resulted in us having a slightly different configuration than upstream.
Thus, in order to make our lifes easier, I think we should refactor the
What needs to get done
Replace the config generator component with a simple yaml template being rendered and pushed in the container.
Definition of Done
Envoy is configurable through a yaml file.
The text was updated successfully, but these errors were encountered:
* Remove the config generation component that used a python package in
order to generate the envoy configuration file. Instead, render a simple `yaml`
file with the proper context.
* Omit the usage of `upstream_service` value (which comes from `mlmd` charm and
by default has the value `metadata-grpc-service`) in naming the `cluster`. This does
not serve any purpose and also makes us diverge from upstream.
Closes#100
Context
We should refactor the charm to be configured using a simple
yaml
file instead of generating it using the envoy_data_plane package for the following reasons.envoy.yaml
file that are visible in PR fix(metadata envoy): upgrade envoy and config from 1.12 to 1.27 kubeflow/pipelines#10589. Regarding those:typed_config
fields are not supported at the moment from the specific package.envoy.yaml
file to the correspond. In other words, it's easier to just copy changes from upstream if we also use ayaml
file.max_grpc_timeout
). This also resulted in us having a slightly different configuration than upstream.Thus, in order to make our lifes easier, I think we should refactor the
What needs to get done
Replace the config generator component with a simple yaml template being rendered and pushed in the container.
Definition of Done
Envoy is configurable through a
yaml
file.The text was updated successfully, but these errors were encountered: