feat: add option for exposing multiple ports#135
Merged
alvaromateo merged 6 commits intomainfrom Jun 6, 2025
Merged
Conversation
5d13b7f to
6d9ecd9
Compare
goulinkh
requested changes
May 27, 2025
Contributor
goulinkh
left a comment
There was a problem hiding this comment.
Looking good, asked for some minor changes.
Thanks for filing this PR :)
5a93df8 to
46ae2ee
Compare
Contributor
Author
|
Thanks for the review @goulinkh ! |
goulinkh
requested changes
May 29, 2025
Co-authored-by: Goulin Khoge <36013798+goulinkh@users.noreply.github.com>
goulinkh
approved these changes
Jun 6, 2025
Contributor
goulinkh
left a comment
There was a problem hiding this comment.
LGTM, thanks for the contribution and applying the changes @alvaromateo :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Done
Add support for exposing multiple ports on the same container.
QA
poetry install --no-interactionDOTRUN_PATH="$(pwd)/.venv/bin/dotrun"$DOTRUN_PATH -p 9008:9008 -p 10008:10008Check in the docker container that all specified ports are exposed. To do this you can run:
And in the output of the command, under the PORTS column you should see all the specified ports.
I tested it on a MacOS. It would be nice to have someone test it on a Linux machine before merging.
Issues
Fixes ISSUES-97