Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Bump o11y libs and remove obsolete juju topology #191

Merged
merged 4 commits into from
May 1, 2024
Merged

chore: Bump o11y libs and remove obsolete juju topology #191

merged 4 commits into from
May 1, 2024

Conversation

orfeas-k
Copy link
Contributor

@orfeas-k orfeas-k requested a review from a team as a code owner April 27, 2024 10:01
DnPlas
DnPlas reviewed Apr 29, 2024
View reviewed changes
Copy link
Contributor

@DnPlas DnPlas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, similar to canonical/notebook-operators#362 (review)

ca-scribner
ca-scribner approved these changes May 1, 2024
View reviewed changes
Copy link
Contributor

@ca-scribner ca-scribner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but the CI integration tests got stuck. Not sure why, but I think it was a flake. I restarted the CI so lets see what it does

@orfeas-k orfeas-k merged commit 0526d10 into main May 1, 2024
7 checks passed
@orfeas-k orfeas-k deleted the kf-5594-bump-o11y-libs branch May 1, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DnPlas DnPlas DnPlas left review comments

@ca-scribner ca-scribner ca-scribner approved these changes

Assignees
No one assigned
Labels
Libraries: Out of sync
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@orfeas-k @DnPlas @ca-scribner