[ISSUE-42;ISSUE-43] is_resource_created improvements and fixes

[deusebio]

Addressing #42 and #43

[welpaolo]

This improvement looks really good. I will also fix the function fetch_relation_data and change the line 504 of the data_interfaces in this way:

if f"{self.relation_name}-relation-broken" in os.environ.get("JUJU_HOOK_NAME", ""):

This will avoid the raise of the runtime exception if the relation-broken event is not related to the database.

[welpaolo]

Looks good to me!

[beliaev-maksim]

@deusebio @welpaolo @delgod
so, you removed in this PR check for relation broken. But then it is not really clear what user did wrong. eg without reading docstring of the function you will never know

could this be improved?

This will avoid the raise of the runtime exception if the relation-broken event is not related to the database.

was not check checking the name of the database relation to ensure it is only related to database relations?

[deusebio]

I'm not sure I fully understand what you mean. IIRC, here the issue is that there may exist multiple relations under the same relation name, and fetch_relation_data fetches the databags for all of them, indexed by the relation id.

Now, previously in the relation_broken_event, we were raising an exception in any relation broken event, which it is a bit too general/broad, as people may still want to access the data for the relations other than the one tearing down. Indeed, this was a use case that some people stumbled upon (OSM team if I recall correctly). I remembered that there was also a somewhat inconsistent behaviour for accessing relation data in integration tests vs unittests (see MM thread here), but this might be a different story.

So, here we basically just fetch the data that can be fetched. If the databag of the relation broken is not available, the dictionary would just NOT have the corresponding relation id key rather than raising an exception. I don't think the users would do anything wrong to use fetch_relation_data in relation_broken_event. Just there may not be some data there. Also, If they try to self.fetch_relation_data()[relation_id] for relations that had been removed, they will get an exception anyway.

[beliaev-maksim]

@deusebio
knowing the context it makes sense :)
however, during execution it might be confusing for users :)