Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support running e2e tests on AWS #45

Open
wants to merge 74 commits into
base: main
Choose a base branch
from
Open

Conversation

eaudetcobello
Copy link
Contributor

@eaudetcobello eaudetcobello commented Aug 19, 2024

cluster_upgrade_test.go → Here we replace the hardcoded reference to docker infrastructure and instead tell the test suite to resolve `. This is then read from the config. file of the test (I think), which lives at test/config/ck8s-{docker,aws}.yaml

create_test.go → same as above.

test/e2e/data/infrastructure-aws folder → this folder contains the templates that will be applied to the cluster during the test.

test/e2e/shared/v1beta1 → this defines the major and minor contract version of the core cluster api components that we use for the tests. (See ck8s-aws.yaml line 25)

test/e2e/shared/v1beta1_aws → this defines the major and minor contract version of the CAPA resources we deploy. (See ck8s-aws.yaml Line 38)

kcp_remediation_test.go, md_remediation_test.go, node_scale_test.go → Changed the hardcoded docker provider to clusterctl.DefaultInfrastructureProvider. Also, skip remediation tests on cloud provider.

Makefile -> added E2E_INFRA variable that can be specified like E2E_INFRA=aws make test-e2e

@eaudetcobello eaudetcobello requested a review from a team as a code owner August 19, 2024 19:07
@eaudetcobello eaudetcobello changed the title Support running e2e tests on aws Support running e2e tests on AWS Aug 19, 2024
Copy link
Contributor

@bschimke95 bschimke95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work @eaudetcobello, added couple of comments
we should probably get #22 in before this.

Makefile Outdated Show resolved Hide resolved
test/e2e/config/ck8s-aws.yaml Show resolved Hide resolved
test/e2e/config/ck8s-aws.yaml Show resolved Hide resolved
test/e2e/create_test.go Show resolved Hide resolved
@eaudetcobello eaudetcobello marked this pull request as draft August 20, 2024 12:51
Makefile Outdated Show resolved Hide resolved
test/e2e/e2e_suite_test.go Outdated Show resolved Hide resolved
@eaudetcobello eaudetcobello force-pushed the KU-1266/e2e-test-aws branch 4 times, most recently from 4764011 to 923b3cf Compare August 24, 2024 01:19
@eaudetcobello eaudetcobello force-pushed the KU-1266/e2e-test-aws branch 21 times, most recently from a259d47 to 9b7796f Compare September 4, 2024 20:44
@eaudetcobello eaudetcobello marked this pull request as ready for review October 22, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants