Initial implementation of passing external datastore parameters #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please resolve conflict |
berkayoz
force-pushed
the
KU-884/capi-external-etcd
branch
from
7c48c7a
to
fde107f
Compare
neoaggelos
reviewed
Jul 9, 2024
neoaggelos
reviewed
Jul 11, 2024
neoaggelos
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added ability to look for certificates for the datastore under the names
$cluster_name-etcd$cluster_name-apiserver-etcd-clientExtended ControlPlane configuration to get
datastoreTypeand a secret reference fordatastoreServersTODO: The naming should be adjusted to reflect
external-datastoreinstead ofetcdin the code and secret names.