CAPI e2e tests #13
Merged
CAPI e2e tests #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bschimke95
commented
Jun 20, 2024
bschimke95
force-pushed
the
KU-968/capi-e2e
branch
5 times, most recently
from
2613e9e
to
d4ee7ed
Compare
bschimke95
force-pushed
the
KU-968/capi-e2e
branch
2 times, most recently
from
3ec9163
to
bb03d5b
Compare
bschimke95
commented
Jun 28, 2024
| @@ -28,7 +28,7 @@ patchesStrategicMerge: | |||
| # Protect the /metrics endpoint by putting it behind auth. | |||
| # If you want your controller-manager to expose the /metrics | |||
| # endpoint w/o any authn/z, please comment the following line. | |||
| - manager_auth_proxy_patch.yaml | |||
| #- manager_auth_proxy_patch.yaml | |||
There was a problem hiding this comment.
Enabling this caused the e2e tests to fail.
bschimke95
force-pushed
the
KU-968/capi-e2e
branch
from
bb03d5b
to
5e4145b
Compare
bschimke95
force-pushed
the
KU-968/capi-e2e
branch
3 times, most recently
from
724f440
to
58c6141
Compare
bschimke95
force-pushed
the
KU-875/provider-images
branch
2 times, most recently
from
fa21655
to
5fc25dd
Compare
bschimke95
force-pushed
the
KU-968/capi-e2e
branch
2 times, most recently
from
d809aa7
to
d044117
Compare
bschimke95
force-pushed
the
KU-968/capi-e2e
branch
2 times, most recently
from
e9e0670
to
4d592c8
Compare
bschimke95
force-pushed
the
KU-968/capi-e2e
branch
from
3964e57
to
ff91102
Compare
bschimke95
force-pushed
the
KU-968/capi-e2e
branch
from
5800779
to
8b1911f
Compare
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
neoaggelos
reviewed
Jul 16, 2024
eaudetcobello
approved these changes
Jul 16, 2024
neoaggelos
reviewed
Jul 16, 2024
neoaggelos
reviewed
Jul 17, 2024
neoaggelos
reviewed
Jul 17, 2024
neoaggelos
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR enables and fixes the e2e tests for our CAPI providers. Specifically they test that:
Right now, the machine upgrade test is disabled as it is more involved. This will be tackled as follow-up work.
Notable changes
Dockerfileto build the providersWaitForNodesReadyfrom the CAPI test framework to thehelpersas we only want to test for the minor Kubernetes version whileframework.WaitForNodesReadydoes a full version check