-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hashes not supported in requirements.txt #1179
Comments
It works with the previous revision of charmcraft (1424). |
Thanks for the report! I'm going to relate #1140 to this too since this is a use case we want to ensure doesn't break when we change the dependency management. This was a use case I didn't consider (for and which we probably need a regression test as we tackle future dependency issues). I'll have to think through options with this. |
charmcraft pinned to 2.3.0 in integration test build but not release build canonical/charmcraft#1179
charmcraft pinned to 2.3.0 in integration test build but not release build canonical/charmcraft#1179
Port over autogeneration of config values from the vm charm Autogenerate config values for the mysql legacy relation Add upterm session to debug failing integration test Always set up upterm session Pass essential env with built charm to upterm session Fix minor bugs + remove upterm github action step Run format [upload-charm-docs] Migrate charm docs (#266) * 'modified: docs/explanation/e-flowcharts.md,docs/explanation/e-interfaces.md,docs/index.md,docs/how-to/h-enable-monitoring.md // new: docs/explanation/e-legacy-charm.md,docs/how-to/h-deploy-gke.md' * 'modified: docs/explanation/e-legacy-charm.md,docs/index.md' * 'modified: docs/how-to/h-deploy-gke.md' --------- Co-authored-by: upload-charms-docs-bot <upload-charms-docs-bot@users.noreply.github.com> DPE-2068 use kill-delay (#258) * use kill-delay * update requirements and delay time DPE-2225 using allocable memory instead of `free` (#256) * using allocable memory instead of `free` * use loose opt modifier * merged from vm * remove comment * fix memory units * set missing trust and testing profile in test * adjust for low memory * test change for ci * fix function call * typing fixes * test wait for maintenance of instance before asserting recovery * extra wait step * strip trailing newline * non-active Fixes for network partition test (#272) * fixes for chaos-mesh * ensure chaos-mesh availability before test * fixes destroy script * function scoped * address pr comment * fix call Port peer juju secret implementation from the vm charm (#263) Upgrade mysql (v0.38) and tls (v0.2) charm libs + minor adjustments [MISC] Revert change on Discourse Sync action (#265) Co-authored-by: upload-charms-docs-bot <upload-charms-docs-bot@users.noreply.github.com> [upload-charm-docs] Migrate charm docs (#266) * 'modified: docs/explanation/e-flowcharts.md,docs/explanation/e-interfaces.md,docs/index.md,docs/how-to/h-enable-monitoring.md // new: docs/explanation/e-legacy-charm.md,docs/how-to/h-deploy-gke.md' * 'modified: docs/explanation/e-legacy-charm.md,docs/index.md' * 'modified: docs/how-to/h-deploy-gke.md' --------- Co-authored-by: upload-charms-docs-bot <upload-charms-docs-bot@users.noreply.github.com> DPE-2068 use kill-delay (#258) * use kill-delay * update requirements and delay time DPE-2225 using allocable memory instead of `free` (#256) * using allocable memory instead of `free` * use loose opt modifier * merged from vm * remove comment * fix memory units * set missing trust and testing profile in test * adjust for low memory * test change for ci * fix function call * typing fixes * test wait for maintenance of instance before asserting recovery * extra wait step * strip trailing newline * non-active Pin python dependencies with Poetry (#273) [MISC] Switch maintainers to the DPE mailing list (#269) * Switch maintainers to the DPE mailing list * Update metadata.yaml Co-authored-by: Carl Csaposs <carl.csaposs@canonical.com> --------- Co-authored-by: Carl Csaposs <carl.csaposs@canonical.com> Pin charmcraft to 2.3.0 in release.yaml to fix build (#276) charmcraft pinned to 2.3.0 in integration test build but not release build canonical/charmcraft#1179 Add missing group markers (#278) Leftover from #273 No integration tests were running since no groups were collected Address PR feedback
Port over autogeneration of config values from the vm charm Autogenerate config values for the mysql legacy relation Add upterm session to debug failing integration test Always set up upterm session Pass essential env with built charm to upterm session Fix minor bugs + remove upterm github action step Run format [upload-charm-docs] Migrate charm docs (#266) * 'modified: docs/explanation/e-flowcharts.md,docs/explanation/e-interfaces.md,docs/index.md,docs/how-to/h-enable-monitoring.md // new: docs/explanation/e-legacy-charm.md,docs/how-to/h-deploy-gke.md' * 'modified: docs/explanation/e-legacy-charm.md,docs/index.md' * 'modified: docs/how-to/h-deploy-gke.md' --------- Co-authored-by: upload-charms-docs-bot <upload-charms-docs-bot@users.noreply.github.com> DPE-2068 use kill-delay (#258) * use kill-delay * update requirements and delay time DPE-2225 using allocable memory instead of `free` (#256) * using allocable memory instead of `free` * use loose opt modifier * merged from vm * remove comment * fix memory units * set missing trust and testing profile in test * adjust for low memory * test change for ci * fix function call * typing fixes * test wait for maintenance of instance before asserting recovery * extra wait step * strip trailing newline * non-active Fixes for network partition test (#272) * fixes for chaos-mesh * ensure chaos-mesh availability before test * fixes destroy script * function scoped * address pr comment * fix call Port peer juju secret implementation from the vm charm (#263) Upgrade mysql (v0.38) and tls (v0.2) charm libs + minor adjustments [MISC] Revert change on Discourse Sync action (#265) Co-authored-by: upload-charms-docs-bot <upload-charms-docs-bot@users.noreply.github.com> [upload-charm-docs] Migrate charm docs (#266) * 'modified: docs/explanation/e-flowcharts.md,docs/explanation/e-interfaces.md,docs/index.md,docs/how-to/h-enable-monitoring.md // new: docs/explanation/e-legacy-charm.md,docs/how-to/h-deploy-gke.md' * 'modified: docs/explanation/e-legacy-charm.md,docs/index.md' * 'modified: docs/how-to/h-deploy-gke.md' --------- Co-authored-by: upload-charms-docs-bot <upload-charms-docs-bot@users.noreply.github.com> DPE-2068 use kill-delay (#258) * use kill-delay * update requirements and delay time DPE-2225 using allocable memory instead of `free` (#256) * using allocable memory instead of `free` * use loose opt modifier * merged from vm * remove comment * fix memory units * set missing trust and testing profile in test * adjust for low memory * test change for ci * fix function call * typing fixes * test wait for maintenance of instance before asserting recovery * extra wait step * strip trailing newline * non-active Pin python dependencies with Poetry (#273) [MISC] Switch maintainers to the DPE mailing list (#269) * Switch maintainers to the DPE mailing list * Update metadata.yaml Co-authored-by: Carl Csaposs <carl.csaposs@canonical.com> --------- Co-authored-by: Carl Csaposs <carl.csaposs@canonical.com> Pin charmcraft to 2.3.0 in release.yaml to fix build (#276) charmcraft pinned to 2.3.0 in integration test build but not release build canonical/charmcraft#1179 Add missing group markers (#278) Leftover from #273 No integration tests were running since no groups were collected Address PR feedback
Dear @lengau , is it possible to release a fix for this regression only? At the moment we have to workaround it in many places (see all the linked commits):
|
This tests various combinations of requirements files and dependencies for regressions. Fixes #1179
This tests various combinations of requirements files and dependencies for regressions. Fixes #1179
This tests various combinations of requirements files and dependencies for regressions. Fixes #1179
@taurus-forever and @carlcsaposs-canonical — could you test the latest charmcraft on edge? This should be fixed there, and if so I can possibly cherry-pick the changes and do a quick release |
@lengau Does that fix #1135 and #1179 simultaneously? From my understanding of the fallback mechanism in #1233, it looks like we can pick 1 of 2 of the issues to be solved, but not both. If my understanding ^ is correct, I believe we are more concerned about #1135 than #1179, so if we have to pick only 1 of 2 issues to be solved, we'd pick #1135—so we wouldn't be using hashes |
Bug Description
#1157 introduced a regression—hashes in requirements.txt cannot be used since PYDEPS requirements do not use hashes, and "hash-checking is an all-or-nothing proposition" (from https://pip.pypa.io/en/stable/topics/secure-installs/#hash-checking-mode)
To Reproduce
Create requirements.txt file with --hash and install a charm lib with PYDEPS
Example: https://github.com/canonical/zookeeper-operator/actions/runs/5651535680
Environment
Ubuntu 22.04
charmcraft.yaml
Relevant log output
The text was updated successfully, but these errors were encountered: