Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin integration tests deployed dependencies of repos [31-39] #866

Closed
DnPlas opened this issue Apr 9, 2024 · 3 comments
Closed

Pin integration tests deployed dependencies of repos [31-39] #866

DnPlas opened this issue Apr 9, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@DnPlas
Copy link
Contributor

DnPlas commented Apr 9, 2024

Context

All the charms that get deployed as dependencies in integration tests must be pinned to their corresponding 1.8 stable channels in the gh:track/ branches. For instance, istio-operators deploy kubeflow-volumes in their integration tests, we must ensure that the last supported stable version of kubeflow-volumes get deployed alongside the last supported stable istio-operators.

Please follow these standards:

For variable naming:

ISTIO_CHANNEL = "1.17/stable"
ISTIO_PILOT = "istio-pilot"
ISTIO_PILOT_TRUST = True
ISTIO_GATEWAY = "istio-gateway"
ISTIO_GATEWAY_APP_NAME = "istio-ingressgateway"
ISTIO_GATEWAY_TRUST = True

For pinning COS charms:

In track/<version> pin the most stable version 1.0/stable and in main please pin the latest/stable version.

You could add a constants.py file to list all the variables and their values and import constants as a module from . import constants so you can use it in your code as constants.SOME_VAR_NAME.

What needs to get done

For gh:track/<version> (for CKF 1.8 corresponding versions)

  1. Get charms 31-39 from the bundle.yaml file.
  2. Go into each charm repo and for all the test.py files where a charm is deployed, pin the channel to the version defined in the bundle definition (file from step 1).
  3. Submit a PR with your changes.

For gh:main make sure all charms that get deployed in integration tests point to latest/stable unless it is recommended otherwise (e.g. mysql-k8s).

Definition of Done

All integration tests run with specific versions of charms that correspond to either CKF 1.8 or latest/stable (or recommended version)

@DnPlas DnPlas added the enhancement New feature or request label Apr 9, 2024
Copy link

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/KF-5541.

This message was autogenerated

ca-scribner added a commit to canonical/minio-operator that referenced this issue Apr 11, 2024
Pins dependencies in the integration tests to their corresponding channels for this release.

Ref: canonical/bundle-kubeflow#866
ca-scribner added a commit to canonical/minio-operator that referenced this issue Apr 11, 2024
Pins dependencies in the integration tests to their corresponding channels for this release.

Ref: canonical/bundle-kubeflow#866
ca-scribner added a commit to canonical/minio-operator that referenced this issue Apr 11, 2024
Pins dependencies in the integration tests to their corresponding channels for this release.

Ref: canonical/bundle-kubeflow#866
ca-scribner added a commit to canonical/oidc-gatekeeper-operator that referenced this issue Apr 12, 2024
Pins dependencies in the integration tests to their corresponding channels for this release.

Ref: canonical/bundle-kubeflow#866
ca-scribner added a commit to canonical/pvcviewer-operator that referenced this issue Apr 12, 2024
Pins dependencies in the integration tests to their corresponding channels for this release.

Ref: canonical/bundle-kubeflow#866
ca-scribner added a commit to canonical/pvcviewer-operator that referenced this issue Apr 12, 2024
Pins dependencies in the integration tests to their corresponding channels for this development branch.

Ref: canonical/bundle-kubeflow#866
ca-scribner added a commit to canonical/seldon-core-operator that referenced this issue Apr 12, 2024
Pins dependencies in the integration tests to their corresponding channels for this release.

Ref: canonical/bundle-kubeflow#866
ca-scribner added a commit to canonical/kubeflow-tensorboards-operator that referenced this issue Apr 12, 2024
Pins dependencies in the integration tests to their corresponding channels for this release.

Ref: canonical/bundle-kubeflow#866
ca-scribner added a commit to canonical/training-operator that referenced this issue Apr 12, 2024
Pins dependencies in the integration tests to their corresponding channels for this release.

Ref: canonical/bundle-kubeflow#866
ca-scribner added a commit to canonical/training-operator that referenced this issue Apr 12, 2024
Pins dependencies in the integration tests to their corresponding channels for this release.

Ref: canonical/bundle-kubeflow#866
kimwnasptd pushed a commit to canonical/training-operator that referenced this issue Apr 15, 2024
Pins dependencies in the integration tests to their corresponding channels for this release.

Ref: canonical/bundle-kubeflow#866
kimwnasptd pushed a commit to canonical/seldon-core-operator that referenced this issue Apr 15, 2024
* pin integration test dependencies, refactor constants in tests

Pins dependencies in the integration tests to their corresponding channels for this release.

Ref: canonical/bundle-kubeflow#866

* fix formatting
kimwnasptd pushed a commit to canonical/pvcviewer-operator that referenced this issue Apr 15, 2024
* pin integration test dependencies

Pins dependencies in the integration tests to their corresponding channels for this release.

Ref: canonical/bundle-kubeflow#866

* fix maximize-build-space action in integration tests

The github runners have changed configuration, requiring different settings in the maximize-build-space action
kimwnasptd pushed a commit to canonical/pvcviewer-operator that referenced this issue Apr 15, 2024
* pin istio integration test dependencies to latest/edge

Pins dependencies in the integration tests to their corresponding channels for this development branch.

Ref: canonical/bundle-kubeflow#866

* fix maximize-build-space action in integration tests

The github runners have changed configuration, requiring different settings in the maximize-build-space action
kimwnasptd pushed a commit to canonical/minio-operator that referenced this issue Apr 15, 2024
* pin integration test dependencies, refactor constants in tests

Pins dependencies in the integration tests to their corresponding channels for this release.

Ref: canonical/bundle-kubeflow#866

* Refactor to remove constants.py

* fix formatting
kimwnasptd pushed a commit to canonical/kubeflow-tensorboards-operator that referenced this issue Apr 15, 2024
…rack/1.8` (#106)

* pin integration test dependencies, refactor constants in tests

Pins dependencies in the integration tests to their corresponding channels for this release.

Ref: canonical/bundle-kubeflow#866

* fix formatting
ca-scribner added a commit to canonical/oidc-gatekeeper-operator that referenced this issue Apr 15, 2024
…ack/ckf-1.8 (#145)

Pins dependencies in the integration tests to their corresponding channels for this release.

Ref: canonical/bundle-kubeflow#866
ca-scribner added a commit to canonical/oidc-gatekeeper-operator that referenced this issue Apr 15, 2024
Pins dependencies in the integration tests to their corresponding channels for this development branch.

Ref: canonical/bundle-kubeflow#866
ca-scribner added a commit to canonical/oidc-gatekeeper-operator that referenced this issue Apr 15, 2024
…in (#146)

Pins dependencies in the integration tests to their corresponding channels for this development branch.

Ref: canonical/bundle-kubeflow#866
@ca-scribner
Copy link
Contributor

Closed because all related PRs have merged

DnPlas pushed a commit to canonical/training-operator that referenced this issue Jun 12, 2024
Pins dependencies in the integration tests to their corresponding channels for this release.

Ref: canonical/bundle-kubeflow#866
DnPlas added a commit to canonical/training-operator that referenced this issue Jun 18, 2024
* pin integration test dependencies, refactor constants in tests (#155)

Pins dependencies in the integration tests to their corresponding channels for this release.

Ref: canonical/bundle-kubeflow#866

Co-authored-by: Andrew Scribner <ca.scribner+1@gmail.com>
DnPlas added a commit to canonical/training-operator that referenced this issue Jun 19, 2024
* pin integration test dependencies, refactor constants in tests (#155)

Pins dependencies in the integration tests to their corresponding channels for this release.

Ref: canonical/bundle-kubeflow#866

Co-authored-by: Andrew Scribner <ca.scribner+1@gmail.com>
DnPlas added a commit to canonical/training-operator that referenced this issue Jun 19, 2024
* pin integration test dependencies, refactor constants in tests (#155)

Pins dependencies in the integration tests to their corresponding channels for this release.

Ref: canonical/bundle-kubeflow#866

Co-authored-by: Andrew Scribner <ca.scribner+1@gmail.com>
DnPlas added a commit to canonical/training-operator that referenced this issue Jul 4, 2024
* pin integration test dependencies, refactor constants in tests (#155)

Pins dependencies in the integration tests to their corresponding channels for this release.

Ref: canonical/bundle-kubeflow#866

Co-authored-by: Andrew Scribner <ca.scribner+1@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants