Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin integration tests deployed dependencies of repos [1-10] #863

Closed
7 tasks done
DnPlas opened this issue Apr 9, 2024 · 2 comments
Closed
7 tasks done

Pin integration tests deployed dependencies of repos [1-10] #863

DnPlas opened this issue Apr 9, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@DnPlas
Copy link
Contributor

DnPlas commented Apr 9, 2024

Context

All the charms that get deployed as dependencies in integration tests must be pinned to their corresponding 1.8 stable channels in the gh:track/ branches. For instance, istio-operators deploy kubeflow-volumes in their integration tests, we must ensure that the last supported stable version of kubeflow-volumes get deployed alongside the last supported stable istio-operators.

Please follow these standards:

For variable naming:

ISTIO_CHANNEL = "1.17/stable"
ISTIO_PILOT = "istio-pilot"
ISTIO_PILOT_TRUST = True
ISTIO_GATEWAY = "istio-gateway"
ISTIO_GATEWAY_APP_NAME = "istio-ingressgateway"
ISTIO_GATEWAY_TRUST = True

For pinning COS charms:

In track/<version> pin the most stable version 1.0/stable and in main please pin the latest/stable version.

You could add a constants.py file to list all the variables and their values and import constants as a module from . import constants so you can use it in your code as constants.SOME_VAR_NAME.

What needs to get done

For gh:track/<version> (for CKF 1.8 corresponding versions)

  1. Get charms 1-10 from the bundle.yaml file.
  2. Go into each charm repo and for all the test.py files where a charm is deployed, pin the channel to the version defined in the bundle definition (file from step 1).
  3. Submit a PR with your changes.

For gh:main make sure all charms that get deployed in integration tests point to latest/stable unless it is recommended otherwise (e.g. mysql-k8s).

List of charms:

  • admission-webhook-operator
  • argo-operators
  • dex-auth-operator
  • envoy-operator
  • istio-operators
  • notebook-operators
  • katib-operators

Definition of Done

All integration tests run with specific versions of charms that correspond to either CKF 1.8 or latest/stable (or recommended version)

@DnPlas DnPlas added the enhancement New feature or request label Apr 9, 2024
Copy link

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/KF-5537.

This message was autogenerated

DnPlas added a commit to canonical/argo-operators that referenced this issue Apr 11, 2024
This commit pins all charms that get deployed from Charmhub to a compatible version to
the CKF 1.8 release. This commit also refactors the test file so it takes all versions and other
constants from a constants.py file

Part of canonical/bundle-kubeflow#863
DnPlas added a commit to canonical/argo-operators that referenced this issue Apr 11, 2024
This commit pins all charms that get deployed from Charmhub to a compatible version to
the CKF 1.8 release. This commit also refactors the test file so it takes all versions and other
constants from a constants.py file

Part of canonical/bundle-kubeflow#863
DnPlas added a commit to canonical/argo-operators that referenced this issue Apr 11, 2024
This commit pins all charms that get deployed from Charmhub to a compatible version to
the CKF 1.8 release. This commit also refactors the test file so it takes all versions and other
constants from a constants.py file

Part of canonical/bundle-kubeflow#863
DnPlas added a commit to canonical/dex-auth-operator that referenced this issue Apr 11, 2024
This commit pins all charms that get deployed from Charmhub to a compatible version to
the CKF 1.8 release. This commit also refactors the test file so it takes all versions and other
constants from a constants.py file

Part of canonical/bundle-kubeflow#863
DnPlas added a commit to canonical/dex-auth-operator that referenced this issue Apr 12, 2024
This commit pins all charms that get deployed from Charmhub to a compatible version to
the CKF 1.8 release. This commit also refactors the test file so it takes all versions and other
constants from a constants.py file

Part of canonical/bundle-kubeflow#863
DnPlas added a commit to canonical/dex-auth-operator that referenced this issue Apr 12, 2024
This commit pins all charms that get deployed from Charmhub to a compatible version to
the CKF 1.8 release. This commit also refactors the test file so it takes all versions and other
constants from a constants.py file

Part of canonical/bundle-kubeflow#863
DnPlas added a commit to canonical/envoy-operator that referenced this issue Apr 12, 2024
This commit pins all charms that get deployed from Charmhub to a compatible version to
the CKF 1.8 release. This commit also refactors the test file so it takes all versions and other
constants from a constants.py file

Part of canonical/bundle-kubeflow#863
DnPlas added a commit to canonical/envoy-operator that referenced this issue Apr 12, 2024
This commit pins all charms that get deployed from Charmhub to a compatible version to
the CKF 1.8 release. This commit also refactors the test file so it takes all versions and other
constants from a constants.py file

Part of canonical/bundle-kubeflow#863
DnPlas added a commit to canonical/envoy-operator that referenced this issue Apr 12, 2024
This commit pins all charms that get deployed from Charmhub to a compatible version to
the CKF 1.8 release. This commit also refactors the test file so it takes all versions and other
constants from a constants.py file

Part of canonical/bundle-kubeflow#863
DnPlas added a commit to canonical/istio-operators that referenced this issue Apr 15, 2024
This commit pins all charms that get deployed from Charmhub to a latest/edge or latest/stable version.
This commit also refactors the test file so it takes all versions and other constants from a constants.py file

Part of canonical/bundle-kubeflow#863
DnPlas added a commit to canonical/notebook-operators that referenced this issue Apr 15, 2024
This commit pins all charms that get deployed from Charmhub to a latest/edge or suggested versions.
This commit also refactors the test file so it takes all versions and other constants from a constants.py file

Part of canonical/bundle-kubeflow#863
DnPlas added a commit to canonical/notebook-operators that referenced this issue Apr 15, 2024
This commit pins all charms that get deployed from Charmhub to a latest/edge or suggested versions.
This commit also refactors the test file so it takes all versions and other constants from a constants.py file

Part of canonical/bundle-kubeflow#863
DnPlas added a commit to canonical/notebook-operators that referenced this issue Apr 15, 2024
This commit pins all charms that get deployed from Charmhub to a latest/edge or suggested versions.
This commit also refactors the test file so it takes all versions and other constants from a constants.py file

Part of canonical/bundle-kubeflow#863
DnPlas added a commit to canonical/katib-operators that referenced this issue Apr 15, 2024
This commit pins all charms that get deployed from Charmhub to a latest/edge or suggested versions.
This commit also refactors the test file so it takes all versions and other constants from a constants.py file

Part of canonical/bundle-kubeflow#863
DnPlas added a commit to canonical/katib-operators that referenced this issue Apr 15, 2024
This commit pins all charms that get deployed from Charmhub to a compatible version to the CKF 1.8 release.
This commit also refactors the test file so it takes all versions and other constants from a constants.py file

Part of canonical/bundle-kubeflow#863
DnPlas added a commit to canonical/katib-operators that referenced this issue Apr 15, 2024
This commit pins all charms that get deployed from Charmhub to a compatible version to the CKF 1.8 release.
This commit also refactors the test file so it takes all versions and other constants from a constants.py file

Part of canonical/bundle-kubeflow#863
DnPlas added a commit to canonical/istio-operators that referenced this issue Apr 15, 2024
This commit pins all charms that get deployed from Charmhub to a compatible version to the CKF 1.8 release.

Part of canonical/bundle-kubeflow#863
DnPlas added a commit to canonical/katib-operators that referenced this issue Apr 15, 2024
This commit pins all charms that get deployed from Charmhub to a latest/edge or suggested versions.
This commit also refactors the test file so it takes all versions and other constants from a constants.py file

Part of canonical/bundle-kubeflow#863
DnPlas added a commit to canonical/katib-operators that referenced this issue Apr 15, 2024
This commit pins all charms that get deployed from Charmhub to a compatible version to the CKF 1.8 release.

Part of canonical/bundle-kubeflow#863
DnPlas added a commit to canonical/argo-operators that referenced this issue Apr 16, 2024
* tests: pin deployed charms to a CKF 1.8 compatible version

This commit pins all charms that get deployed from Charmhub to a latest/edge or suggested versions.
Part of canonical/bundle-kubeflow#863
DnPlas added a commit to canonical/argo-operators that referenced this issue Apr 16, 2024
* tests: pin deployed charms to a CKF 1.8 compatible version

This commit pins all charms that get deployed from Charmhub to a compatible version to the CKF 1.8 release.

Part of canonical/bundle-kubeflow#863
DnPlas added a commit to canonical/dex-auth-operator that referenced this issue Apr 16, 2024
* tests: pin deployed charms to a CKF 1.8 compatible version

This commit pins all charms that get deployed from Charmhub to a compatible version to the CKF 1.8 release.

Part of canonical/bundle-kubeflow#863
DnPlas added a commit to canonical/envoy-operator that referenced this issue Apr 16, 2024
…86)

* tests: pin deployed charms to a latest and stable compatible version

This commit pins all charms that get deployed from Charmhub to a latest/edge or suggested versions.

Part of canonical/bundle-kubeflow#863
DnPlas added a commit to canonical/envoy-operator that referenced this issue Apr 16, 2024
* tests: pin deployed charms to a CKF 1.8 compatible version


This commit pins all charms that get deployed from Charmhub to a compatible version to the CKF 1.8 release.

Part of canonical/bundle-kubeflow#863
DnPlas added a commit to canonical/istio-operators that referenced this issue Apr 16, 2024
…408)

* tests: pin deployed charms to a latest and stable compatible version

This commit pins all charms that get deployed from Charmhub to a latest/edge or suggested versions.

Part of canonical/bundle-kubeflow#863
DnPlas added a commit to canonical/katib-operators that referenced this issue Apr 16, 2024
This commit pins all charms that get deployed from Charmhub to a compatible version to the CKF 1.8 release.

Part of canonical/bundle-kubeflow#863
DnPlas added a commit to canonical/katib-operators that referenced this issue Apr 16, 2024
This commit pins all charms that get deployed from Charmhub to a latest/edge or suggested versions.

Part of canonical/bundle-kubeflow#863
DnPlas added a commit to canonical/notebook-operators that referenced this issue Apr 16, 2024

This commit pins all charms that get deployed from Charmhub to a compatible version to the CKF 1.8 release.

Part of canonical/bundle-kubeflow#863
DnPlas added a commit to canonical/dex-auth-operator that referenced this issue Apr 16, 2024
…190)

This commit pins all charms that get deployed from Charmhub to a latest/edge or suggested versions.

Part of canonical/bundle-kubeflow#863
DnPlas added a commit to canonical/notebook-operators that referenced this issue Apr 16, 2024
This commit pins all charms that get deployed from Charmhub to a latest/edge or suggested versions.
Part of canonical/bundle-kubeflow#863
DnPlas added a commit to canonical/istio-operators that referenced this issue Apr 17, 2024
This commit pins all charms that get deployed from Charmhub to a compatible version to the CKF 1.8 release.
Part of canonical/bundle-kubeflow#863
DnPlas added a commit to canonical/notebook-operators that referenced this issue Apr 18, 2024
This commit pins all charms that get deployed from Charmhub to a compatible version to the CKF 1.8 release.
This commit only affects individual integration tests.

Part of canonical/bundle-kubeflow#863
DnPlas added a commit to canonical/notebook-operators that referenced this issue Apr 18, 2024
This commit pins all charms that get deployed from Charmhub to a recommended latest and stable.
This commit only affects individual integration tests.

Part of canonical/bundle-kubeflow#863
DnPlas added a commit to canonical/notebook-operators that referenced this issue Apr 22, 2024
* tests: pin deployed charms to latest and stable versions

This commit pins all charms that get deployed from Charmhub to a recommended latest and stable.
This commit only affects individual integration tests.

Part of canonical/bundle-kubeflow#863
DnPlas added a commit to canonical/notebook-operators that referenced this issue Apr 22, 2024
* tests: pin deployed charms to CKF 1.8 compatible versions

This commit pins all charms that get deployed from Charmhub to a compatible version to the CKF 1.8 release.
This commit only affects individual integration tests.

Part of canonical/bundle-kubeflow#863
@DnPlas
Copy link
Contributor Author

DnPlas commented Apr 22, 2024

All repositories now have pinned versions. Closing this issue.

@DnPlas DnPlas closed this as completed Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant