Tls: add custom_ssl_context parameter #1161
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a custom_ssl_context parameter to `Tls()` that makes it possible to pass a custom `ssl.SSLContext` object for the TLS connection, allowing configurations not supported in the current code, such as more recent options like [ssl.SSLContext.verify_flags](https://docs.python.org/3.11/library/ssl.html#ssl.SSLContext.verify_flags). One use case is to enable [partial certificate chain verification](https://docs.python.org/3.11/library/ssl.html#ssl.VERIFY_X509_PARTIAL_CHAIN) for pinning certificates in situations where a root certificate is not available.
ThePirateWhoSmellsOfSunflowers
added a commit
to ThePirateWhoSmellsOfSunflowers/ldap3
that referenced
this pull request
Oct 25, 2024
Add a custom_ssl_context parameter to `Tls()` that makes it possible to pass a custom `ssl.SSLContext` object for the TLS connection, allowing configurations not supported in the current code, such as more recent options like [ssl.SSLContext.verify_flags](https://docs.python.org/3.11/library/ssl.html#ssl.SSLContext.verify_flags). One use case is to enable [partial certificate chain verification](https://docs.python.org/3.11/library/ssl.html#ssl.VERIFY_X509_PARTIAL_CHAIN) for pinning certificates in situations where a root certificate is not available.
Co-authored-by: ThePirateWhoSmellsOfSunflowers <ThePirateWhoSmellsOfSunflowers@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a custom_ssl_context parameter to
Tls()to pass a customssl.SSLContextobject for TLS connections. This allows configurations that currently are not supported in the code, such as more recent ssl options like ssl.SSLContext.verify_flags.One use case is to enable partial certificate chain verification for pinning certificates in situations where a root certificate is not available.