Skip to content

New Copy & Run button styles implementation #568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 16, 2019
Merged

New Copy & Run button styles implementation #568

merged 4 commits into from
Sep 16, 2019

Conversation

cherifGsoul
Copy link
Member

phillipskevin
phillipskevin approved these changes Aug 15, 2019
View reviewed changes
Copy link
Contributor

@phillipskevin phillipskevin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this works fine (other than the one small comment). I don't know a ton about this code though.

static/prism.less Outdated
top: 0 !important;
right: 0 !important;
border-left: 1px #dfdfdf solid;
border-bottom: 1px #dfdfdf solid;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you fix this indenting?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, thanks!

chasenlehara
chasenlehara requested changes Aug 19, 2019
View reviewed changes
Copy link
Member

@chasenlehara chasenlehara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn’t look quite right (buttons over the expand bar):
Screen Shot 2019-08-19 at 3 35 34 PM

I don’t see the Run button integrated into the toolbar. Should that be in this PR?

static/prism.less Outdated
> .toolbar {
line-height: 0;
top: 0 !important;
right: 0 !important;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the !important necessary? If yes right now, can we use a more specific selector to override the other styles, or are there other styles that should be removed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, thanks

static/prism.less Outdated
color: #858585 !important;
padding: .35em 2.25em !important;
box-shadow: none !important;
border-radius: 0 !important;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same thing for the !important in the rest of this file. We should avoid them if at all possible.

@cherifGsoul
Copy link
Member Author

This doesn’t look quite right (buttons over the expand bar):

What is not right, the style or Run button is missed?

I don’t see the Run button integrated into the toolbar. Should that be in this PR?

@chasenlehara did you update bit-docs-html-codepen-link to major?

bit-docs-html-canjs/make-example.js

Line 31 in 5543af3

"bit-docs-html-codepen-link": "^1.0.0",

@cherifGsoul
Copy link
Member Author

@chasenlehara I updated the styles, for notes, buttons toolbar is a sibling to the collapsible bar parent.
I updated the make-example.js with the last major of bit-docs-html-codepen-link

@cherifGsoul cherifGsoul merged commit 5a742c1 into master Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phillipskevin phillipskevin phillipskevin approved these changes

@jamiemccue jamiemccue Awaiting requested review from jamiemccue

@chasenlehara chasenlehara Awaiting requested review from chasenlehara

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement the new copy & run buttons
3 participants
@cherifGsoul @phillipskevin @chasenlehara