Fix a bug causing resources with relative paths to load the wrong URL #371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imaustink
commented
Jul 6, 2017
| @@ -218,6 +218,9 @@ function navigate(href) { | |||
| return xhr; | |||
| }, | |||
| success: function(content) { | |||
|
|
|||
| window.history.pushState(null, null, href); | |||
There was a problem hiding this comment.
@chasenlehara I think this is where we want it.
chasenlehara
approved these changes
Jul 6, 2017
imaustink
commented
Jul 6, 2017
static/canjs.js
Outdated
| @@ -25,6 +25,10 @@ var $articleContainer, | |||
| hasShownSearch; | |||
|
|
|||
| (function() { | |||
|
|
|||
| // Google Analytics | |||
| ga('send', 'pageview', window.location.pathname); | |||
There was a problem hiding this comment.
@chasenlehara don't we already send the initial page load here:
There was a problem hiding this comment.
You are right, thanks for pointing that out! I’ve removed my commit.
chasenlehara
force-pushed
the
fix-relative-paths
branch
from
e4e6f0e to
7563419
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We highjack clicks on
<a>tags and use Ajax to load the content in. If we don't change the URL withpushStatebefore we load the content into the DOM, all relative paths will be based off the previous page's URL. This causing the issue Justin reported in slack: https://bitovi.slack.com/archives/C09R50SAE/p1499289090158230