Fix search results and keep them working in Safari #364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don’t really need to test whether there were more than 0 results _and_ more than 1 result.
chasenlehara
requested changes
Jun 30, 2017
| @@ -320,6 +320,7 @@ var Search = Control.extend({ | |||
| if (index && currentIndexVersion === indexVersion) { | |||
| searchEngine = lunr.Index.load(index); | |||
| }else{ | |||
| var dummyContainer = document.createElement('div'); | |||
There was a problem hiding this comment.
We need to not use the DOM if we’re going to move this code to a web worker.
There was a problem hiding this comment.
@chasenlehara would it be acceptable to use striptags? I can't find a better solution without using the DOM.
There was a problem hiding this comment.
I merged this as-is and worked around it by running this code before the items are sent to the web worker.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.