Scroll nav to current menu item #348
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
imaustink
commented
Jun 23, 2017
imaustink
commented
chasenlehara
requested changes
Jun 26, 2017
static/canjs.js
Outdated
| @@ -87,6 +87,7 @@ function init() { | |||
| buildTOC(); | |||
| setNavToggleListener(); | |||
| setScrollPosition(); | |||
| scrollToCurrentMenuItem(); | |||
There was a problem hiding this comment.
I think this should only be run when the page first loads, not in init. As-is, the navigation will change as people click on different links, but I think we only want this behavior on the first page load.
chasenlehara
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.