Skip to content

Align the search icon and placeholder #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 2, 2017
Merged

Align the search icon and placeholder #295

merged 2 commits into from
Jun 2, 2017

Conversation

imaustink
Copy link
Contributor

@imaustink imaustink commented Jun 2, 2017 •
edited
Loading

Moved search input up by 2px under the advice of @jamiemccue.

Before:
image

After:
screen shot 2017-06-02 at 11 15 59 am

@imaustink imaustink requested a review from chasenlehara June 2, 2017 18:18
chasenlehara
chasenlehara approved these changes Jun 2, 2017
View reviewed changes
Copy link
Member

@chasenlehara chasenlehara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@chasenlehara chasenlehara changed the title Align the search icon and placeholder. close #287 Align the search icon and placeholder Jun 2, 2017
@imaustink imaustink merged commit 9490db6 into master Jun 2, 2017
@chasenlehara chasenlehara deleted the 287-align-search-icon branch June 2, 2017 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chasenlehara chasenlehara chasenlehara approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@imaustink @chasenlehara