Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a mechanism for producing masks based on simple image contrast #6

Open
WilliamJudge94 opened this issue Aug 10, 2019 · 2 comments
Assignees

Comments

@WilliamJudge94
Copy link
Collaborator

Using the O K-edge with some ptychography data produces masks that are inverted (maybe?) from what they should be (i.e. 1's mark active material instead of background). We need to review the various edge combinations to make sure they're at least all consistent.

Also, there should be a page in the docs about using masks.

@canismarko
Copy link
Owner

Turns out this is the result of the underlying data, the edge jump happens to be relatively high in the background. This motivated the development of a second form of masking, named (contrast mask). @WilliamJudge94 is developing this.

@canismarko canismarko changed the title Masks are inverted Implement a mechanism for producing masks based on simple image contrast Aug 12, 2019
@canismarko
Copy link
Owner

Code was completed with 0646af2, but the documentation needs a little cleaning up. 40f9779 added documentation on how to use the contrast mask, and lists one drawback of the absorption edge masking approach. We should list the benefits of XAS edge masking and the benefits and drawbacks of contrast masking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants