Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle label and order by biologic suffix in merge groups #418

Merged
merged 5 commits into from
Apr 15, 2024

Conversation

jsstevenson
Copy link
Member

@jsstevenson jsstevenson commented Apr 12, 2024

close #299

Two related issues

  1. If a normalized drug already has a label, other labels in the group should be added as aliases
  2. RxNorm provides records for biosimilars that have a four character suffix but are otherwise the same as the base drug in their name. That base name should be the label of the normalized group, and the drug labeled with that name should be the primary concept ID for the group.

Without this PR, we end up with silly drug pages on dgidb like this:

Screenshot 2024-04-12 at 10 43 22 AM

@jsstevenson jsstevenson added the priority:medium Medium priority label Apr 12, 2024
@jsstevenson jsstevenson marked this pull request as ready for review April 12, 2024 18:12
src/therapy/etl/merge.py Outdated Show resolved Hide resolved
@jsstevenson jsstevenson requested a review from korikuzma April 13, 2024 13:55
@jsstevenson jsstevenson merged commit ed95fb2 into main Apr 15, 2024
21 checks passed
@jsstevenson jsstevenson deleted the bio-suffix branch April 15, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:medium Medium priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't use suffixed biologic term for normalized label if possible
2 participants