-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/bwamem2 #54
Merged
Merged
Feature/bwamem2 #54
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
5b7812d
Changes required to provide a merging script which is aware of mmQc
keiranmraine 83b7a15
Add travis verification of new script install
keiranmraine f164bc1
switch to more formal path lookups
keiranmraine 4904f77
Detail changes and fix some markdown errors
keiranmraine 0b3c0c3
This would do a full switch to bwa-mem2, probably want it to be optio…
keiranmraine 62f70a1
Show content of log in direct output as well as file it is from
keiranmraine 7b6f57a
bwa-mem2 and efficiency in merging steps
keiranmraine 355b204
install bwa-mem2 in setup.sh also, as well as move URL for release in…
keiranmraine File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
This would do a full switch to bwa-mem2, probably want it to be optio…
…nal, but default
- Loading branch information
commit 0b3c0c36aaa2c5d71152ccdb9ad27da0e27a28f9
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -32,6 +32,7 @@ subtest 'Initialisation checks' => sub { | |
|
||
subtest 'Non object checks' => sub { | ||
ok(PCAP::Bwa::bwa_version(), 'Version returned for BWA'); | ||
ok(PCAP::Bwa::bwamem2_version(), 'Version returned for bwa-mem2'); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Confirm version check works |
||
}; | ||
|
||
done_testing(); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bwa-mem2 has a much cleaner version string... root command is different too