Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix root cert color when self-signed #4912

Merged
merged 3 commits into from
Oct 25, 2023
Merged

Fix root cert color when self-signed #4912

merged 3 commits into from
Oct 25, 2023

Conversation

FestiveKyle
Copy link
Collaborator

@FestiveKyle FestiveKyle commented Oct 24, 2023 •
edited
Loading

Adds passedValidation property to certificate chain results. Only set shown certificates as red on frontend if they are self-signed and do not pass validation.

Also adds the Hostname Matches property to the leaf certificate, changing the cert to red if the hostname does not match.

Closes #4259

  • Do not make self-signed cert red if it passes validation:
    image

  • New Hostname Matches field on leaf cert.
    image

lcampbell2
lcampbell2 approved these changes Oct 25, 2023
View reviewed changes
Copy link
Collaborator

@lcampbell2 lcampbell2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@FestiveKyle FestiveKyle merged commit 47c7f14 into master Oct 25, 2023
24 checks passed
@FestiveKyle FestiveKyle deleted the fix-root-cert-color branch October 25, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lcampbell2 lcampbell2 lcampbell2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check if invidiual certificates are included in trust store (check for root certs)
2 participants
@FestiveKyle @lcampbell2