-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: The invocation of a non-existing function returns null #692
Commits on Jul 24, 2023
-
test: Adjust expected behavior of function invocation
If a function is invoked with wrong parameter, the invocation should return null (instead of failing the evaluation).
Configuration menu - View commit details
-
Copy full SHA for bcd43ec - Browse repository at this point
Copy the full SHA bcd43ecView commit details -
feat: Return null on function invocation
A function invocation returns null if the function is invoked with wrong parameters, or no function exists with this name.
Configuration menu - View commit details
-
Copy full SHA for 10aae21 - Browse repository at this point
Copy the full SHA 10aae21View commit details -
Change the name of some test cases to bring the focus on the invocation of functions.
Configuration menu - View commit details
-
Copy full SHA for 902239b - Browse repository at this point
Copy the full SHA 902239bView commit details -
test: New test case for function invocation
Add new test cases for a function invocation that return null.
Configuration menu - View commit details
-
Copy full SHA for f866321 - Browse repository at this point
Copy the full SHA f866321View commit details
Commits on Jul 25, 2023
-
test: Verify reported failures
If a function invocation returns null, we want to verify that a failure is reported. A user of the API can access the evaluation failures to understand why an evaluation returned null. So, we should verify the reported failures. To verify the failures, we need a new base test class that returns the whole evaluation result, instead of only the return value. Create a new test matcher to increase the readability of the tests and better failure messages.
Configuration menu - View commit details
-
Copy full SHA for 70bca2f - Browse repository at this point
Copy the full SHA 70bca2fView commit details -
refactor: Use evaluation result matcher in test
Migrate the test class from FeelIntegrationTest to FeelEngineTest. The new base test class allows using the EvaluationResultMatchers that can check for reported failures and produces better failure messages.
Configuration menu - View commit details
-
Copy full SHA for d2ca767 - Browse repository at this point
Copy the full SHA d2ca767View commit details -
refactor: Replace internal test methods
Replace the internal test methods by using FeelEngineTest and EvaluationResultMatchers.
Configuration menu - View commit details
-
Copy full SHA for b79573d - Browse repository at this point
Copy the full SHA b79573dView commit details -
refactor: Align failure message
Align the failure message if no function was found.
Configuration menu - View commit details
-
Copy full SHA for 0260126 - Browse repository at this point
Copy the full SHA 0260126View commit details -
Move test case from SuppressedFailuresTest to InterpreterFunctionTest that bundles all function related test cases. Remove test cases from SuppressedFailuresTest that are already covered in InterpreterFunctionTest.
Configuration menu - View commit details
-
Copy full SHA for 133dc8f - Browse repository at this point
Copy the full SHA 133dc8fView commit details