feat: AWS AgentCore Memory Outbound Connector implementation#6498
feat: AWS AgentCore Memory Outbound Connector implementation#6498mathieu-stennier wants to merge 19 commits intomainfrom
Conversation
…icai/aiagent/memory/conversation/awsagentcore/mapping/README.md Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…icai/aiagent/memory/conversation/awsagentcore/README.md Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…icai/aiagent/memory/conversation/awsagentcore/README.md Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…icai/aiagent/memory/conversation/awsagentcore/README.md Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…icai/autoconfigure/AgenticAiConnectorsAutoConfiguration.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| ArgumentCaptor<DocumentCreationRequest> captor = | ||
| ArgumentCaptor.forClass(DocumentCreationRequest.class); |
Check notice
Code scanning / CodeQL
Unread local variable Note test
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 2 months ago
In general, to fix an unread local variable in a test, either remove the variable declaration if it is unnecessary, or use it in assertions/verification if it was meant to validate behavior. Here, the argument captor is not used at all; the test already validates the constructed DocumentCreationRequest through JSON parsing in spyFactory. The simplest, safest fix is to delete the unused ArgumentCaptor<DocumentCreationRequest> captor declaration.
Concretely, in connectors/aws/aws-agentcore-memory/src/test/java/io/camunda/connector/aws/agentcore/memory/AwsAgentCoreMemoryExecutorTest.java, in the shouldFlattenContentFromText test, remove lines 171–172:
ArgumentCaptor<DocumentCreationRequest> captor =
ArgumentCaptor.forClass(DocumentCreationRequest.class);No additional methods, imports, or definitions are required, and no other code in this method depends on captor.
| @@ -168,8 +168,6 @@ | ||
| when(client.retrieveMemoryRecords(any(RetrieveMemoryRecordsRequest.class))) | ||
| .thenReturn(sdkResponse); | ||
|
|
||
| ArgumentCaptor<DocumentCreationRequest> captor = | ||
| ArgumentCaptor.forClass(DocumentCreationRequest.class); | ||
| Function<DocumentCreationRequest, Document> spyFactory = | ||
| req -> { | ||
| // Verify JSON content |
|
@mathieu-stennier Are you still working on this or can we close it? |
maff
force-pushed
the
mathieu-aws-agent-core-memory
branch
8 times, most recently
from
e19f8b4 to
4d7041f
Compare
4 participants
Description
Related issues
closes #
Checklist
release, as this branch will be rebased onto main before the next release. Example backport labels:
backport stable/8.8: for changes that should be included in the next 8.8.x release.backport release-8.8.7: for changes that should be included in the specific release 8.8.7, and thisrelease has already been created. The release branch will be merged back into stable/8.8 later, so the change
will be included in future 8.8.x releases as well.