Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(admin): fix display of usage metrics > 12 months #4778

Merged
merged 2 commits into from
Nov 18, 2024
Merged

fix(admin): fix display of usage metrics > 12 months #4778

merged 2 commits into from
Nov 18, 2024

Conversation

tasso94
Copy link
Member

@tasso94 tasso94 commented Nov 7, 2024

related to #4743

@tasso94 tasso94 added the ci:e2e Runs the frontend end-to-end tests. label Nov 7, 2024
@tasso94 tasso94 requested a review from venetrius November 7, 2024 16:11
@tasso94 tasso94 self-assigned this Nov 7, 2024
@tasso94 tasso94 mentioned this pull request Nov 7, 2024
Closed
1 task
venetrius
venetrius requested changes Nov 13, 2024
View reviewed changes
Copy link
Member

@venetrius venetrius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ The graph's title is Usage last 12 months by month but the graph shows data for 24 months.
image
❓ Changing the contract start data, has no effect on the data shown. I am not sure if this is an issue or expected
image

@tasso94
Copy link
Member Author

tasso94 commented Nov 14, 2024

❌ The graph's title is Usage last 12 months by month but the graph shows data for 24 months.

Good catch! 👍

❓ Changing the contract start data, has no effect on the data shown. I am not sure if this is an issue or expected

That's expected. It shows the last 12 months.

@tasso94 tasso94 force-pushed the 4743-fix-admin-execution-metrics branch from 3288222 to 59fedf8 Compare November 14, 2024 15:54
@tasso94 tasso94 requested a review from venetrius November 15, 2024 09:44
venetrius
venetrius approved these changes Nov 15, 2024
View reviewed changes
Copy link
Member

@venetrius venetrius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 nice!

@tasso94 tasso94 added bot:backport:7.21 Backports PR to maintenance branch 7.21. bot:backport:7.22 labels Nov 18, 2024
@tasso94 tasso94 merged commit 4d17b90 into master Nov 18, 2024
9 checks passed
@tasso94 tasso94 deleted the 4743-fix-admin-execution-metrics branch November 18, 2024 08:55
@ap-development-workflow
Copy link

Successfully created backport PR for 7.21:

  • camunda/camunda-bpm-platform-maintenance#1306

@ap-development-workflow
Copy link

Successfully created backport PR for 7.22:

  • camunda/camunda-bpm-platform-maintenance#1307

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@venetrius venetrius venetrius approved these changes

Assignees

@tasso94 tasso94

Labels
bot:backport:7.21 Backports PR to maintenance branch 7.21. bot:backport:7.22 ci:e2e Runs the frontend end-to-end tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tasso94 @venetrius