Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): update google tag manager #4773

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

venetrius
Copy link
Member

related to: camunda/team-automation-platform/issues/160

@venetrius venetrius self-assigned this Nov 6, 2024
@venetrius
Copy link
Member Author

Testing changes for rest docs:

I run mvn clean install from /engine-rest/docs and verified engine-rest/docs/target/index.html contains the script tag.
Verified that when loading a local html file a request was sent to: https://ssgtm.camunda.org

Testing changes for javadocs:

I run mvn javadoc:javadoc -Pjavadocs from engine and checked the html files in engine/target/site/apidocs
Verified that when loading a local javadoc html a request was sent to: https://ssgtm.camunda.org

@venetrius venetrius requested a review from tasso94 November 6, 2024 14:46
@venetrius venetrius changed the title chore(docs): update google doc manager chore(docs): update google tag manager Nov 6, 2024
Copy link
Member

@tasso94 tasso94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 👍

@venetrius venetrius merged commit 4bf19e5 into master Nov 8, 2024
4 checks passed
@venetrius venetrius deleted the 160-update-google-tag-manager branch November 8, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants