Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(javadocs): include google tag manager #4673

Merged
merged 1 commit into from
Oct 4, 2024
Merged

chore(javadocs): include google tag manager #4673

merged 1 commit into from
Oct 4, 2024

Conversation

venetrius
Copy link
Member

related to: camunda/team-automation-platform/issues/160

@venetrius venetrius self-assigned this Oct 3, 2024
@venetrius
Copy link
Member Author

venetrius commented Oct 3, 2024 •
edited
Loading

For testing I run mvn javadoc:javadoc -Pjavadocs from engine and checked the html files in engine/target/site/apidocs
Verified that when loading a local javadoc html a request was successfully sent to: https://www.googletagmanager.com/gtm.js?id=XXXXXXXXXXX

danielkelemen
danielkelemen approved these changes Oct 3, 2024
View reviewed changes
Copy link
Member

@danielkelemen danielkelemen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@venetrius venetrius merged commit 8b9ae68 into master Oct 4, 2024
2 checks passed
@venetrius venetrius deleted the 160-javadocs-include-google-tag-manager branch October 4, 2024 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielkelemen danielkelemen danielkelemen approved these changes

Assignees

@venetrius venetrius

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@venetrius @danielkelemen