Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update "old version" in maven #4669

Merged
merged 12 commits into from
Oct 9, 2024
Merged

Update "old version" in maven #4669

merged 12 commits into from
Oct 9, 2024

Conversation

psavidis
Copy link
Contributor

@psavidis psavidis commented Oct 1, 2024

Related-to: #4278

@psavidis psavidis self-assigned this Oct 1, 2024
@psavidis psavidis mentioned this pull request Oct 1, 2024
Closed
@psavidis
Copy link
Contributor Author

psavidis commented Oct 1, 2024 •
edited
Loading

Notes for the Reviewer

Below you can find a table which maps each section to the respective changes to ease up the review.

Camunda Platform code changes

Step Change
Update "old version" in maven Commit
Add instance migration project Commit
Adjust create scripts Commit
Create upgrade scripts Commit
Add the new changeSets to liquibase Commit

Links

@yanavasileva
Copy link
Member

CI labels that it's good to be added: migration, rolling-update, all-db (or h2). As at the moment, not all changes are tested.
I expect some failures then. They should be fixed with the subtasks of this ticket #4278.
image

@psavidis psavidis force-pushed the camunda-platform-code-changes branch from 0fc1971 to 388f0bb Compare October 7, 2024 10:16
@psavidis psavidis marked this pull request as ready for review October 7, 2024 10:16
@psavidis psavidis requested review from yanavasileva and removed request for yanavasileva October 7, 2024 10:16
@psavidis psavidis requested review from danielkelemen and yanavasileva and removed request for danielkelemen October 7, 2024 10:16
@yanavasileva
Copy link
Member

@psavidis, you need to run the CI as pointed previously: #4669 (comment)

yanavasileva
yanavasileva requested changes Oct 7, 2024
View reviewed changes
Copy link
Member

@yanavasileva yanavasileva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ test-fixture 7.23 is missing here:

camunda-bpm-platform/qa/test-db-instance-migration/pom.xml

Line 44 in 388f0bb

<module>test-fixture-722</module>

❌ CI has not been triggered yet to test the changes.

engine/src/main/resources/org/camunda/bpm/engine/db/upgrade/db2_engine_7.22_to_7.23.sql Show resolved Hide resolved
qa/test-old-engine/pom.xml Outdated Show resolved Hide resolved
@venetrius venetrius added ci:migration Runs the process instance migration builds. ci:all-db Runs the builds for all databases. ci:rolling-update Runs the rolling update builds. labels Oct 7, 2024
@venetrius
Copy link
Member

❌ test-fixture 7.23 is missing here:

camunda-bpm-platform/qa/test-db-instance-migration/pom.xml

Line 44 in 388f0bb

<module>test-fixture-722</module>

❌ CI has not been triggered yet to test the changes.

Added text fixture for 7.23
Added CI labels to run stages that test the changes

@venetrius venetrius assigned venetrius and unassigned psavidis Oct 7, 2024
@venetrius venetrius mentioned this pull request Oct 7, 2024
Closed
1 task
@venetrius
Copy link
Member

Pushed commit to remove telemetry settings from old-engine cfg.

@yanavasileva
Copy link
Member

yanavasileva commented Oct 7, 2024 •
edited
Loading

Pushed commit to remove telemetry settings from old-engine cfg.

This should be cleaned up too to fix the current failures in daily/sidetrack:

@yanavasileva
Copy link
Member

This version should be changed too to 7.22.0:
https://github.com/camunda/camunda-bpm-platform/blob/master/spin/pom.xml#L29

@yanavasileva
Copy link
Member

The rest looks good, only two comments are left as TODO.

@venetrius venetrius force-pushed the camunda-platform-code-changes branch from 0943bbf to 68afdae Compare October 8, 2024 06:31
yanavasileva
yanavasileva approved these changes Oct 8, 2024
View reviewed changes
Copy link
Member

@yanavasileva yanavasileva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Changes look good to me. Please wait for CI feedback before you merge.

@venetrius venetrius mentioned this pull request Oct 8, 2024
Merged
@venetrius venetrius merged commit 396d635 into master Oct 9, 2024
1 of 2 checks passed
@venetrius venetrius deleted the camunda-platform-code-changes branch October 9, 2024 06:36
@github-actions github-actions bot mentioned this pull request Oct 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@venetrius venetrius venetrius left review comments

@yanavasileva yanavasileva yanavasileva approved these changes

Assignees

@venetrius venetrius

Labels
ci:all-db Runs the builds for all databases. ci:migration Runs the process instance migration builds. ci:rolling-update Runs the rolling update builds.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@psavidis @yanavasileva @venetrius @danielkelemen