[CAM-10647] Case-Insensitive Variable Search for multiple Queries #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* CaseExecutionQuery * CaseInstanceQuery * ExecutionQuery * HistoricCaseInstanceQuery * HistoricProcessInstanceQuery * VariableInstanceQuery Related to CAM-10647
* CaseExecutionQuery * CaseInstanceQuery * ExecutionQuery * HistoricCaseInstanceQuery * HistoricProcessInstanceQuery * VariableInstanceQuery Related to CAM-10647
to match other REST query tests with case-insensitive variable search Related to CAM-10647
yanavasileva
requested changes
Jul 25, 2019
There was a problem hiding this comment.
Please check my comments together with:
createVariableInstanceQuery#variableNameIn(link) does not support ignore case, do we want to implement it there as well? Otherwise, we should explicitly document it. (Note, I don't think#variableNameInis exposed to the REST API)- Tests cases to cover (java + rest api test):
--createExecutionQuery().processVariableValueXXX()
--createCaseExecutionQuery().caseInstanceVariableValueXXX()
--createVariableInstanceQuery.variableNameLike()
engine/src/main/resources/org/camunda/bpm/engine/impl/mapping/entity/VariableInstance.xml
Outdated
Show resolved
Hide resolved
engine/src/main/resources/org/camunda/bpm/engine/impl/mapping/entity/VariableInstance.xml
Outdated
Show resolved
Hide resolved
.../src/test/java/org/camunda/bpm/engine/test/api/variables/AbstractVariableIgnoreCaseTest.java
Show resolved
Hide resolved
.../src/test/java/org/camunda/bpm/engine/test/api/variables/AbstractVariableIgnoreCaseTest.java
Show resolved
Hide resolved
engine/src/main/java/org/camunda/bpm/engine/runtime/VariableInstanceQuery.java
Show resolved
Hide resolved
engine/src/main/java/org/camunda/bpm/engine/runtime/VariableInstanceQuery.java
Show resolved
Hide resolved
yanavasileva
approved these changes
Jul 25, 2019
nlr234
pushed a commit
to nlr234/camunda-bpm-platform
that referenced
this pull request
Aug 1, 2019
* ProcessInstanceQuery * CaseExecutionQuery * CaseInstanceQuery * ExecutionQuery * HistoricCaseInstanceQuery * HistoricProcessInstanceQuery * VariableInstanceQuery Related to CAM-10647, CAM-10395, Closes camunda#416
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://app.camunda.com/jira/browse/CAM-10647
Related to CAM-10647