-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(project): switch to jdk 11 source code level #3691
Conversation
TODO:
|
Dependency Tree Diff
|
33898c5
to
7d69366
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 The changes look really good, well done!
🔧 I think there are more modules that use Maven profiles with an activation condition <jdk>[11,)</jdk>
that can be adjusted, e.g. engine-cdi
, engine-rest
, examples
, and webapps
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's wait for CI feedback but I have nothing to add, well done! 👍
#3690