Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(engine): respect user when deleting auth for group memberships #3565

Merged
merged 2 commits into from
Jul 12, 2023
Merged

fix(engine): respect user when deleting auth for group memberships #3565

merged 2 commits into from
Jul 12, 2023

Conversation

tasso94
Copy link
Member

@tasso94 tasso94 commented Jul 6, 2023

related to #3564

@tasso94 tasso94 added ci:h2 Runs the builds for the H2 database. ci:no-build Prevents any CI stage from running. labels Jul 6, 2023
@tasso94 tasso94 self-assigned this Jul 6, 2023
@tasso94 tasso94 mentioned this pull request Jul 6, 2023
Closed
@tasso94 tasso94 added ci:authorizations and removed ci:h2 Runs the builds for the H2 database. ci:no-build Prevents any CI stage from running. labels Jul 7, 2023
@tasso94 tasso94 force-pushed the 3564-fix-auth-deletion-group-memberships branch from 6d21891 to 149a316 Compare July 7, 2023 11:48
@yanavasileva
Copy link
Member

@tasso94 please note that the ci:authorizations is obsolete, you can use h2 or default-build labels to trigger the db-UNIT-h2 stage which performs the authorizations tests now and all-db for the other databases.

@tasso94 tasso94 added ci:h2 Runs the builds for the H2 database. ci:no-build Prevents any CI stage from running. and removed ci:authorizations labels Jul 10, 2023
@tasso94
Copy link
Member Author

tasso94 commented Jul 10, 2023

Recent commit is only cosmetical. Please see the CI of the previous commit:
https://ci-pipeline.cambpm.camunda.cloud/job/7.20/job/cambpm-ce/job/cambpm-daily/job/PR-3565/1/display/redirect
https://ci-pipeline.cambpm.camunda.cloud/job/7.20/job/cambpm-ee/job/cambpm-ee-main-pr/job/master/121/display/redirect
https://ci-pipeline.cambpm.camunda.cloud/job/7.20/job/cambpm-ce/job/cambpm-main/job/PR-3565/3/display/redirect

@tasso94 tasso94 requested a review from yanavasileva July 10, 2023 14:48
yanavasileva
yanavasileva approved these changes Jul 12, 2023
View reviewed changes
Copy link
Member

@yanavasileva yanavasileva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good. I just added a note on something that I observed, no action needed.

engine/src/main/java/org/camunda/bpm/engine/impl/identity/db/DbIdentityServiceProvider.java Show resolved Hide resolved
@tasso94 tasso94 merged commit 32b97f7 into master Jul 12, 2023
@tasso94 tasso94 deleted the 3564-fix-auth-deletion-group-memberships branch July 12, 2023 07:57
mboskamp pushed a commit that referenced this pull request Sep 19, 2023
@tasso94 @mboskamp
fix(engine): respect user when deleting auth for group memberships (#…
65356d7 
…3565)

related to #3564
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yanavasileva yanavasileva yanavasileva approved these changes

Assignees

@tasso94 tasso94

Labels
ci:h2 Runs the builds for the H2 database. ci:no-build Prevents any CI stage from running.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tasso94 @yanavasileva