Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(engine+webapps): simplify revoke ALWAYS tests #3540

Merged
merged 2 commits into from
Jul 5, 2023
Merged

test(engine+webapps): simplify revoke ALWAYS tests #3540

merged 2 commits into from
Jul 5, 2023

Conversation

tmetzke
Copy link
Member

@tmetzke tmetzke commented Jul 3, 2023

  • Removes repeated authorization test cases (~1600) for revoke mode ALWAYS. Instead, ensures that mode ALWAYS leads equivalent queries compared to when AUTO mode triggers. The latter is well-tested, ensuring ALWAYS works as well.

related to #3530

@tmetzke
test(engine+webapps): simplify revoke ALWAYS tests
6a3d446 
* Removes repeated authorization test cases (~1600) for revoke mode ALWAYS.
  Instead, ensures that mode ALWAYS leads equivalent queries compared to when
  AUTO mode triggers. The latter is well-tested, ensuring ALWAYS works as well.

related to #3530
@tmetzke tmetzke added the ci:all-db Runs the builds for all databases. label Jul 3, 2023
@tmetzke tmetzke self-assigned this Jul 3, 2023
@tmetzke tmetzke linked an issue Jul 3, 2023 that may be closed by this pull request
Remove revoke mode ALWAYS test executions #3530
Closed
1 task
@tmetzke tmetzke mentioned this pull request Jul 3, 2023
Closed
1 task
@tmetzke tmetzke requested a review from tasso94 July 3, 2023 09:33
tasso94
tasso94 approved these changes Jul 5, 2023
View reviewed changes
Copy link
Member

@tasso94 tasso94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement! 👍

@tmetzke tmetzke merged commit d0a7e11 into master Jul 5, 2023
@tmetzke tmetzke deleted the 3530-revoke-mode-always branch July 5, 2023 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tasso94 tasso94 tasso94 approved these changes

Assignees

@tmetzke tmetzke

Labels
ci:all-db Runs the builds for all databases.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove revoke mode ALWAYS test executions
2 participants
@tmetzke @tasso94