Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(swaggerui): bump version #3520

Merged
merged 5 commits into from
Jul 3, 2023
Merged

chore(swaggerui): bump version #3520

merged 5 commits into from
Jul 3, 2023

Conversation

danielkelemen
Copy link
Member

@danielkelemen danielkelemen commented Jun 21, 2023 •
edited
Loading

  • use frontend-maven-plugin

related to #3200

@danielkelemen danielkelemen self-assigned this Jun 21, 2023
@danielkelemen
Copy link
Member Author

There are two errors on Jenkins (NodeJS version: 14.6.0):

g++: error: unrecognized command line option ‘-std=c++17’

  • Update gcc on the CI? Or revert some dependency versions.

[webpack-cli] HookWebpackError: Only file and data URLs are supported by the default ESM loader

  • Maybe because of the NodeJS version? It doesn't happen locally with NodeJS 14.21.3.

@tasso94
Copy link
Member

tasso94 commented Jun 26, 2023 •
edited
Loading

@danielkelemen, maybe we need to use a newer NodeJS version? Can we use the Maven frontend plugin for swaggerUI as well? This would make us more independent of the Infra team. Cf. how we do it for the web apps already: https://github.com/camunda/camunda-bpm-platform/blob/master/webapps/pom.xml#L159-L170
Afterwards, we could clean up the installation of NodeJS 14.6 by the CI.
Edit: Clean up only possible as soon as REST Docs are migrated to the Maven frontend plugin as well.

@danielkelemen
Copy link
Member Author

@tasso94 Yeah, this is the way. Should I update rest-docs too?

@tasso94
Copy link
Member

tasso94 commented Jun 26, 2023

@danielkelemen, that would be great!

@danielkelemen danielkelemen requested a review from tasso94 June 26, 2023 17:04
tasso94
tasso94 reviewed Jun 27, 2023
View reviewed changes
Copy link
Member

@tasso94 tasso94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me in general 👍

  • ❓ Should we adjust the CI file for the daily pipeline to check if staging the REST docs works?
  • ❓ Should we run Run integration tests?

parent/pom.xml Show resolved Hide resolved
distro/run/modules/swaggerui/pom.xml Outdated Show resolved Hide resolved
engine-rest/docs/pom.xml Outdated Show resolved Hide resolved
@danielkelemen danielkelemen added the ci:run Runs the integration tests for the Run distribution. label Jun 28, 2023
@danielkelemen @tasso94
Apply suggestions from code review
32f6d9f 
Co-authored-by: tasso94 <3015690+tasso94@users.noreply.github.com>
@danielkelemen danielkelemen added the ci:default-build Runs the builds that have no explicit trigger (e.g. different history levels). label Jun 28, 2023
@danielkelemen danielkelemen force-pushed the 3200-swaggerui branch 2 times, most recently from f88f72e to a95f8cb Compare June 29, 2023 10:35
@danielkelemen danielkelemen requested a review from tasso94 June 29, 2023 13:51
tasso94
tasso94 approved these changes Jun 30, 2023
View reviewed changes
Copy link
Member

@tasso94 tasso94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

distro/run/modules/swaggerui/ui/webpack.config.js Outdated Show resolved Hide resolved
distro/run/modules/swaggerui/ui/package.json Outdated Show resolved Hide resolved
.ci/daily/Jenkinsfile Outdated Show resolved Hide resolved
danielkelemen and others added 2 commits July 3, 2023 11:20
@danielkelemen
add missing license texts
14779e0
@danielkelemen @tasso94
Apply suggestions from code review
8bc7654 
Co-authored-by: tasso94 <3015690+tasso94@users.noreply.github.com>
@danielkelemen danielkelemen merged commit da3c34d into master Jul 3, 2023
@danielkelemen danielkelemen deleted the 3200-swaggerui branch July 3, 2023 09:23
@danielkelemen danielkelemen mentioned this pull request Jul 3, 2023
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tasso94 tasso94 tasso94 approved these changes

Assignees

@danielkelemen danielkelemen

Labels
ci:default-build Runs the builds that have no explicit trigger (e.g. different history levels). ci:run Runs the integration tests for the Run distribution.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danielkelemen @tasso94