Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(webapps): use asset module instead of loaders #3494

Merged
merged 1 commit into from
Jul 3, 2023
Merged

refactor(webapps): use asset module instead of loaders #3494

merged 1 commit into from
Jul 3, 2023

Conversation

tasso94
Copy link
Member

@tasso94 tasso94 commented Jun 8, 2023

related to #3401

@tasso94 tasso94 added ci:e2e Runs the frontend end-to-end tests. ci:no-build Prevents any CI stage from running. labels Jun 8, 2023
@tasso94 tasso94 self-assigned this Jun 8, 2023
@tasso94 tasso94 force-pushed the webpack-windows branch from e968cea to 8a8f3f0 Compare June 8, 2023 09:28
@tasso94 tasso94 removed the ci:no-build Prevents any CI stage from running. label Jun 8, 2023
@tasso94 tasso94 requested a review from danielkelemen June 8, 2023 11:18
@tasso94 tasso94 changed the title fix(webapps): refactor to use asset module instead of loaders refactor(webapps): use asset module instead of loaders Jun 8, 2023
danielkelemen
danielkelemen approved these changes Jul 3, 2023
View reviewed changes
Copy link
Member

@danielkelemen danielkelemen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@tasso94 tasso94 added the ci:no-build Prevents any CI stage from running. label Jul 3, 2023
@tasso94 tasso94 merged commit 3001745 into master Jul 3, 2023
@tasso94 tasso94 deleted the webpack-windows branch July 3, 2023 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielkelemen danielkelemen danielkelemen approved these changes

Assignees

@tasso94 tasso94

Labels
ci:e2e Runs the frontend end-to-end tests. ci:no-build Prevents any CI stage from running.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tasso94 @danielkelemen