Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cockpit): load report fonts correctly #3483

Merged
merged 1 commit into from
Jun 26, 2023
Merged

fix(cockpit): load report fonts correctly #3483

merged 1 commit into from
Jun 26, 2023

Conversation

tasso94
Copy link
Member

@tasso94 tasso94 commented Jun 6, 2023

related to #3242, #3462

@tasso94 tasso94 added ci:e2e Runs the frontend end-to-end tests. ci:no-build Prevents any CI stage from running. labels Jun 6, 2023
@tasso94 tasso94 self-assigned this Jun 6, 2023
@tasso94 tasso94 removed the ci:no-build Prevents any CI stage from running. label Jun 6, 2023
@tasso94
Copy link
Member Author

tasso94 commented Jun 6, 2023

I couldn't make it work keeping the reporting fonts in the enterprise edition.

@tasso94 tasso94 requested a review from danielkelemen June 6, 2023 13:19
danielkelemen
danielkelemen approved these changes Jun 19, 2023
View reviewed changes
Copy link
Member

@danielkelemen danielkelemen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@tasso94 tasso94 merged commit 060d3dd into master Jun 26, 2023
@tasso94 tasso94 deleted the 3462-fix-load-report-fonts branch June 26, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielkelemen danielkelemen danielkelemen approved these changes

Assignees

@tasso94 tasso94

Labels
ci:e2e Runs the frontend end-to-end tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tasso94 @danielkelemen