Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(engine): drop handling JPA entities as variables #3468

Merged
merged 16 commits into from
Jun 12, 2023
Merged

chore(engine): drop handling JPA entities as variables #3468

merged 16 commits into from
Jun 12, 2023

Conversation

yanavasileva
Copy link
Member

@yanavasileva yanavasileva added ci:default-build Runs the builds that have no explicit trigger (e.g. different history levels). ci:spring-boot Runs the integration tests for the Spring Boot starter. labels May 30, 2023
@yanavasileva yanavasileva self-assigned this May 30, 2023
@yanavasileva yanavasileva marked this pull request as draft May 30, 2023 12:58
@yanavasileva yanavasileva added the ci:all-as Runs the builds for all application servers. label May 30, 2023
@yanavasileva yanavasileva force-pushed the 3447-drop-handling-jpa-entities-as-variables branch 3 times, most recently from 2e81f59 to ddb7f7e Compare May 31, 2023 16:00
@yanavasileva yanavasileva added the ci:webapp-integration Runs the webapp integration builds. label Jun 7, 2023
@yanavasileva yanavasileva mentioned this pull request Jun 7, 2023
Closed
7 tasks
@yanavasileva yanavasileva requested a review from tmetzke June 7, 2023 08:50
@yanavasileva
Copy link
Member Author

The build failed after a Jenkins restart. I retriggered a new one:

Base automatically changed from 3436-run-jdk17-compatible to master June 7, 2023 11:38
tmetzke
tmetzke reviewed Jun 8, 2023
View reviewed changes
Copy link
Member

@tmetzke tmetzke left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Core removals of JPA look good to me. Since the CI looks pretty good so far as well, I think you're on a really good track here.
❓ Would you mind rebasing the PR to make it more focused? I believe some of the commits in here are already on the main branch (e.g. JDK 17 readiness).

@yanavasileva yanavasileva added the ci:no-build Prevents any CI stage from running. label Jun 8, 2023
@yanavasileva yanavasileva force-pushed the 3447-drop-handling-jpa-entities-as-variables branch from 3cf0dbb to 3df5446 Compare June 8, 2023 12:17
@yanavasileva yanavasileva removed the ci:no-build Prevents any CI stage from running. label Jun 8, 2023
@yanavasileva yanavasileva marked this pull request as ready for review June 8, 2023 12:21
@yanavasileva
Copy link
Member Author

Branch rebased against master. Commits left "unsquashed" for now, to have history reference of the progress.

tmetzke
tmetzke reviewed Jun 8, 2023
View reviewed changes
Copy link
Member

@tmetzke tmetzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks really good to me still after a second run-through.
❓ I added some understanding questions along the way.
❓ I couldn't find an explanation for moving some engine-spring classes to an impl package (but I might have also just missed it), would you mind either quickly explaining or pointing me to an existing explanation? 🙂

qa/test-db-instance-migration/test-fixture-719/pom.xml Outdated Show resolved Hide resolved
...ration/src/test/java/org/camunda/bpm/qa/upgrade/scenarios7190/variables/JpaEntitiesTest.java Outdated Show resolved Hide resolved
internal-dependencies/pom.xml Show resolved Hide resolved
@yanavasileva yanavasileva force-pushed the 3447-drop-handling-jpa-entities-as-variables branch from 2a5bba0 to e9a5455 Compare June 9, 2023 10:56
@yanavasileva
Copy link
Member Author

❓ I couldn't find an explanation for moving some engine-spring classes to an impl package (but I might have also just missed it), would you mind either quickly explaining or pointing me to an existing explanation?

Initially, we planned to restructure the module and introduce an implementation package to divide the private API from public API. After reconsidering this aspect again, we will save the users' effort to migrate their code and drop this refactoring for now. (e9a5455)

@tmetzke
Copy link
Member

tmetzke commented Jun 12, 2023

Initially, we planned to restructure the module and introduce an implementation package to divide the private API from public API. After reconsidering this aspect again, we will save the users' effort to migrate their code and drop this refactoring for now. (e9a5455)

This will make it easier for existing users, of course. 👍 Thanks for following up 🙂

tmetzke
tmetzke approved these changes Jun 12, 2023
View reviewed changes
Copy link
Member

@tmetzke tmetzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, nicely done 👍

@yanavasileva yanavasileva merged commit 876ae80 into master Jun 12, 2023
@yanavasileva yanavasileva deleted the 3447-drop-handling-jpa-entities-as-variables branch June 12, 2023 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmetzke tmetzke tmetzke approved these changes

Assignees

@yanavasileva yanavasileva

Labels
ci:all-as Runs the builds for all application servers. ci:default-build Runs the builds that have no explicit trigger (e.g. different history levels). ci:spring-boot Runs the integration tests for the Spring Boot starter. ci:webapp-integration Runs the webapp integration builds.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yanavasileva @tmetzke