Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(cdi): remove weld 1 support #3421

Merged
merged 2 commits into from
Jul 5, 2023
Merged

chore(cdi): remove weld 1 support #3421

merged 2 commits into from
Jul 5, 2023

Conversation

danielkelemen
Copy link
Member

@danielkelemen danielkelemen commented May 15, 2023 •
edited
Loading

related to #3522

@danielkelemen danielkelemen added the ci:all-as Runs the builds for all application servers. label May 15, 2023
@danielkelemen danielkelemen self-assigned this May 15, 2023
@danielkelemen danielkelemen force-pushed the 2985-quarkus3-define branch from dea5c5e to ffd98db Compare June 14, 2023 14:13
Base automatically changed from 2985-quarkus3-define to master June 21, 2023 12:31
@yanavasileva yanavasileva added the ci:default-build Runs the builds that have no explicit trigger (e.g. different history levels). label Jun 23, 2023
yanavasileva
yanavasileva reviewed Jun 23, 2023
View reviewed changes
Copy link
Member

@yanavasileva yanavasileva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ Do we want to bump the weld version used for testing Tomcat? Link:

camunda-bpm-platform/qa/integration-tests-engine/pom.xml

Lines 238 to 244 in 66f2e64

<!-- weld for CDI support on tomcat-->
<dependency>
<groupId>org.jboss.weld.servlet</groupId>
<artifactId>weld-servlet</artifactId>
<version>1.1.10.Final</version>
<scope>test</scope>
</dependency>

engine-cdi/pom.xml Outdated Show resolved Hide resolved
engine-cdi/core/pom.xml Show resolved Hide resolved
@camunda camunda deleted a comment from github-actions bot Jun 27, 2023
@camunda camunda deleted a comment from github-actions bot Jun 27, 2023
@danielkelemen danielkelemen force-pushed the 2985-drop-weld1 branch 2 times, most recently from 59b9b29 to 253c5fa Compare July 4, 2023 14:27
@danielkelemen
- bump weld servlet in IT
b9d29e9 
- remove weld from QA integration-tests-engine
@danielkelemen
Copy link
Member Author

I thought weld-servlet-shaded@3.1.9.Final - which is the replacement of the old weld-servlet - would work but it did not. I updated to the latest weld-servlet@2.4.8.Final. This looks good.

@yanavasileva
Copy link
Member

I have checked weld-servlet-core-3.1.9.Final and weld-servlet-test-tomcat-3.1.9.Final and they also doesn't seem like a replacement of the dependency that we use at the moment for Tomcat IT.

yanavasileva
yanavasileva approved these changes Jul 5, 2023
View reviewed changes
Copy link
Member

@yanavasileva yanavasileva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks for following the review hints.

@danielkelemen danielkelemen merged commit f42e994 into master Jul 5, 2023
@danielkelemen danielkelemen deleted the 2985-drop-weld1 branch July 5, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yanavasileva yanavasileva yanavasileva approved these changes

Assignees

@danielkelemen danielkelemen

Labels
ci:all-as Runs the builds for all application servers. ci:default-build Runs the builds that have no explicit trigger (e.g. different history levels).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danielkelemen @yanavasileva