Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(webapps): retry test server start when port bound #3398

Merged
merged 1 commit into from
Jun 9, 2023

Conversation

tmetzke
Copy link
Member

@tmetzke tmetzke commented May 5, 2023

  • Retries a failed test server start in case the port is still bound.
    The start will be retried 3 times at maximum. There will be a backoff
    of half a second between retries.

related to #2598

@tmetzke tmetzke added the ci:all-db Runs the builds for all databases. label May 5, 2023
@tmetzke tmetzke self-assigned this May 5, 2023
@tmetzke tmetzke force-pushed the 2598-header-rule-random-port branch 3 times, most recently from 71c47bd to c5d56db Compare June 8, 2023 05:06
@tmetzke tmetzke force-pushed the 2598-header-rule-random-port branch from fb29d80 to 839b863 Compare June 8, 2023 11:47
* Retries a failed test server start in case the port is still bound.
  The start will be retried 3 times at maximum. There will be a backoff
  of half a second between retries.

related to #2598
@tmetzke tmetzke force-pushed the 2598-header-rule-random-port branch from 839b863 to d25bd9f Compare June 8, 2023 11:52
@tmetzke tmetzke changed the title chore(webapps): use random port in HeaderRule chore(webapps): retry test server start when port bound Jun 8, 2023
@tmetzke tmetzke requested a review from mboskamp June 8, 2023 15:08
Copy link
Member

@mboskamp mboskamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good

@tmetzke tmetzke merged commit 2de6229 into master Jun 9, 2023
@tmetzke tmetzke deleted the 2598-header-rule-random-port branch June 9, 2023 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:all-db Runs the builds for all databases.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants