Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(webapps): use angularjs from xlts.dev #1842

Merged
merged 7 commits into from
Apr 20, 2022
Merged

chore(webapps): use angularjs from xlts.dev #1842

merged 7 commits into from
Apr 20, 2022

Conversation

tasso94
Copy link
Member

@tasso94 tasso94 commented Mar 16, 2022

related to CAM-14395

@tasso94 tasso94 self-assigned this Mar 16, 2022
@tasso94 tasso94 added e2e and removed no-build labels Mar 16, 2022
@tasso94 tasso94 force-pushed the CAM-14395-angularjs-xlts-dev branch 2 times, most recently from 6b8d71f to 94ab658 Compare March 17, 2022 12:09
@tasso94 tasso94 added e2e and removed no-build labels Mar 17, 2022
@tasso94 tasso94 requested a review from danielkelemen March 18, 2022 14:37
@tasso94 tasso94 added e2e and removed no-build labels Mar 18, 2022
danielkelemen
danielkelemen approved these changes Mar 21, 2022
View reviewed changes
Copy link
Member

@danielkelemen danielkelemen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@tasso94
Copy link
Member Author

tasso94 commented Apr 6, 2022 •
edited
Loading

⚠️ Adjust or remove the example that bundles AngularJS before merging: https://github.com/camunda/camunda-bpm-examples/tree/master/sdk-js/browser-forms-angular

Edit: With CAM-14596, I created a follow-up ticket to take care of this.

@tasso94 tasso94 force-pushed the CAM-14395-angularjs-xlts-dev branch from e7cadcc to 76e170d Compare April 20, 2022 11:46
@tasso94 tasso94 merged commit b5413ea into master Apr 20, 2022
@tasso94 tasso94 deleted the CAM-14395-angularjs-xlts-dev branch April 20, 2022 13:37
@tasso94 tasso94 restored the CAM-14395-angularjs-xlts-dev branch May 3, 2022 06:35
@tasso94 tasso94 deleted the CAM-14395-angularjs-xlts-dev branch May 3, 2022 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielkelemen danielkelemen danielkelemen approved these changes

Assignees

@tasso94 tasso94

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tasso94 @danielkelemen