Skip to content

Comments

refactor(e2e): replace fixed sleep with polling helpers in smoke test#76

Draft
Copilot wants to merge 2 commits intoe2e-smoke-testfrom
copilot/sub-pr-74
Draft

refactor(e2e): replace fixed sleep with polling helpers in smoke test#76
Copilot wants to merge 2 commits intoe2e-smoke-testfrom
copilot/sub-pr-74

Conversation

Copy link
Contributor

Copilot AI commented Feb 20, 2026

The c8_cmd wrapper used a fixed sleep after state-changing commands, making the smoke test flaky — assertions could fire before indexing completed on slow systems, or waste time on fast ones.

Changes

  • Removed c8_cmd and C8_WAIT_TIME — the sleep-based propagation wait is gone entirely
  • Added poll_until / poll_until_absent — retry the verification command every second until the expected condition appears (or disappears) or C8_TIMEOUT (default: 30 s) is reached
  • Updated all state-change-then-verify flows to use the new helpers:
Test After command Polling condition
Deploy process deploy list pd contains simple-process
Run + list pi run list pi contains $INSTANCE_KEY
User task (appear) run list ut has a leading-digit line
User task (gone) complete ut list ut absent $UT_KEY
Message correlation (active) create pi list pi contains $INSTANCE_KEY
Message correlation (done) publish msg list pi absent ${INSTANCE_KEY}.*ACTIVE
  • Removed duplicate test_pass function definition
  • Added C8_TIMEOUT env var (default: 30) to allow per-environment tuning
# Example: run with a longer timeout on a slow environment
C8_TIMEOUT=60 ./smoke-test.sh

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

…helpers

Co-authored-by: mschoe <2777965+mschoe@users.noreply.github.com>
Copilot AI changed the title [WIP] Address feedback on E2E smoke test implementation refactor(e2e): replace fixed sleep with polling helpers in smoke test Feb 20, 2026
Copilot AI requested a review from mschoe February 20, 2026 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants