Skip to content

Comments

Fix parseArgs flag handling for --variables option#69

Merged
vobu merged 3 commits intofeat/process-instance-diagramfrom
copilot/sub-pr-60-one-more-time
Feb 18, 2026
Merged

Fix parseArgs flag handling for --variables option#69
vobu merged 3 commits intofeat/process-instance-diagramfrom
copilot/sub-pr-60-one-more-time

Conversation

Copy link
Contributor

Copilot AI commented Feb 18, 2026

The --variables flag was checked via process.argv.includes('--variables') instead of using the parsed value, breaking syntaxes like --variables=true and being inconsistent with parseArgs patterns.

Changes

  • Use Boolean(values.variables) instead of process.argv.includes('--variables') to match existing --diagram flag pattern
  • Supports all flag syntaxes: --variables, --variables=true, etc.
// Before
const includeVariables = process.argv.includes('--variables');

// After  
const includeVariables = Boolean(values.variables);

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI and others added 2 commits February 18, 2026 14:18
Co-authored-by: vobu <6573426+vobu@users.noreply.github.com>
Co-authored-by: vobu <6573426+vobu@users.noreply.github.com>
Copilot AI changed the title [WIP] WIP Address feedback on PI diagram rendering implementation Fix parseArgs flag handling for --variables option Feb 18, 2026
Copilot AI requested a review from vobu February 18, 2026 14:22
@vobu vobu marked this pull request as ready for review February 18, 2026 14:23
@vobu vobu merged commit 514b420 into feat/process-instance-diagram Feb 18, 2026
1 check passed
@vobu vobu deleted the copilot/sub-pr-60-one-more-time branch February 18, 2026 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants