Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example with external tasks #631

Merged
merged 3 commits into from
Dec 27, 2023
Merged

Conversation

ingorichtsmeier
Copy link
Contributor

@ingorichtsmeier ingorichtsmeier commented Dec 19, 2023

Description

Add a Camunda 7 Example application with external service task. And migrate it using the camunda-7-adapter.

Additional context

Some people are struggling with the correct configuration and dependencies. And we have no running example right now.

Testing your changes

Both applications, Camunda 7 and migrated, contain unit tests to run and assert process instances.

Types of changes

  • Bug fix (non-breaking change which fixes an existing open issue)
  • New feature (non-breaking change which adds functionality to an extension)
  • Breaking change (fix or feature that would cause existing functionality of an extension to change)
  • Documentation update (changes made to an existing piece of documentation)

Checklist:

  • My code adheres to the syntax used by this extension.
  • My pull request requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the Camunda Community Hub documentation.
  • I have read the Pull Request Process documentation.
  • I have added or suggested tests to cover my changes suggested in this pull request.
  • All new and existing CI/CD tests passed.
  • I will /assign myself this issue, and add the relevant [issue labels] to it if they are not automatically generated by Probot.
  • I will tag @camunda-community-hub/devrel in a new comment on this issue if 30 days have passed since my pull request was opened and I have not received a response from the extension's maintainer.

Copy link

Test Results

  25 files  +  25    25 suites  +25   1m 42s ⏱️ + 1m 42s
221 tests +221  221 ✔️ +221  0 💤 ±0  0 ±0 
337 runs  +337  337 ✔️ +337  0 💤 ±0  0 ±0 

Results for commit 14a3472. ± Comparison against base commit 6137a4f.

Copy link
Collaborator

@jonathanlukas jonathanlukas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@ingorichtsmeier ingorichtsmeier merged commit 3dec75f into main Dec 27, 2023
5 checks passed
@jonathanlukas jonathanlukas deleted the example-external-tasks branch February 16, 2024 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants