Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: [adapter] Object variables in adapter #386

Merged
merged 3 commits into from
Sep 4, 2023

Conversation

jonathanlukas
Copy link
Collaborator

Description

Until now, it was not possible to use typed variables from the adapter delegateExecution as typing is not handled by the engine anymore.

This PR adds a mechanism to define typing rules for variables based on their names and the bpmnProcessId.

Additional context

closes #299

Testing your changes

For the tests, a rule has been registered and applied to the test delegate which can now handle the typed object.

Types of changes

  • Bug fix (non-breaking change which fixes an existing open issue)
  • New feature (non-breaking change which adds functionality to an extension)
  • Breaking change (fix or feature that would cause existing functionality of an extension to change)
  • Documentation update (changes made to an existing piece of documentation)

Checklist:

  • My code adheres to the syntax used by this extension.
  • My pull request requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the Camunda Community Hub documentation.
  • I have read the Pull Request Process documentation.
  • I have added or suggested tests to cover my changes suggested in this pull request.
  • All new and existing CI/CD tests passed.
  • I will /assign myself this issue, and add the relevant [issue labels] to it if they are not automatically generated by Probot.
  • I will tag @camunda-community-hub/devrel in a new comment on this issue if 30 days have passed since my pull request was opened and I have not received a response from the extension's maintainer.

@jonathanlukas jonathanlukas changed the title fix [adapter]: Object variables in adapter bugfix: [adapter] Object variables in adapter Sep 4, 2023
@jonathanlukas jonathanlukas self-assigned this Sep 4, 2023
@github-actions
Copy link

github-actions bot commented Sep 4, 2023

Test Results

  24 files  ±0    24 suites  ±0   2m 0s ⏱️ +5s
212 tests ±0  212 ✔️ ±0  0 💤 ±0  0 ±0 
328 runs  ±0  328 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit e9c19ba. ± Comparison against base commit 2737310.

@jonathanlukas jonathanlukas merged commit b70b746 into main Sep 4, 2023
4 checks passed
@jonathanlukas jonathanlukas deleted the bugfix/object-variables-in-adapter branch September 4, 2023 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Camunda-7-Adapter cannot handle Object process variables
1 participant