Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notify the docker image and the installation information in the back… #336

Merged
merged 2 commits into from
Aug 2, 2023

Conversation

pierre-yves-monnet
Copy link
Contributor

…end-diagram-converter README.

Camunda Community Hub Pull Request Template

Description

Notify the docker image in the documentation for the backend converter

Additional context

It was not very clear that a docker image existed. In the backend documentation, the only mention is "how to build the application", so to install it, the first step seems to be to build it first.
But a docker image exists, ready to use, and it is better to start to mention it, before the build.

Testing your changes

Only documentation

Types of changes

  • Bug fix (non-breaking change which fixes an existing open issue)
  • New feature (non-breaking change which adds functionality to an extension)
  • Breaking change (fix or feature that would cause existing functionality of an extension to change)
  • [X ] Documentation update (changes made to an existing piece of documentation)

Checklist:

  • My code adheres to the syntax used by this extension.
  • My pull request requires a change to the documentation.
  • [X ] I have updated the documentation accordingly.
  • [X ] I have read the Camunda Community Hub documentation.
  • [X ] I have read the Pull Request Process documentation.
  • I have added or suggested tests to cover my changes suggested in this pull request.
  • All new and existing CI/CD tests passed.
  • I will /assign myself this issue, and add the relevant [issue labels] to it if they are not automatically generated by Probot.
  • I will tag @camunda-community-hub/devrel in a new comment on this issue if 30 days have passed since my pull request was opened and I have not received a response from the extension's maintainer.

@github-actions
Copy link

github-actions bot commented Aug 2, 2023

Test Results

  26 files  +  26    26 suites  +26   2m 16s ⏱️ + 2m 16s
214 tests +214  214 ✔️ +214  0 💤 ±0  0 ±0 
332 runs  +332  332 ✔️ +332  0 💤 ±0  0 ±0 

Results for commit 052dc99. ± Comparison against base commit 6e67daa.

♻️ This comment has been updated with latest results.

@ingorichtsmeier ingorichtsmeier merged commit 6bcaa94 into main Aug 2, 2023
3 checks passed
@jonathanlukas jonathanlukas deleted the doc_startconverterwebapp branch September 15, 2023 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants