Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix][converter/core]: Empty error code leads to conversion error #316

Merged
merged 1 commit into from
Jul 10, 2023

Conversation

jonathanlukas
Copy link
Collaborator

Camunda Community Hub Pull Request Template

Description

In Camunda 7, it is ok to leave out the error code in a error to create a catch-all error.

This could not be converted as it lead to a null-pointer exception.

Additional context

closes #315

Testing your changes

There is a new test added asserting the correct behaviour.

Types of changes

  • Bug fix (non-breaking change which fixes an existing open issue)
  • New feature (non-breaking change which adds functionality to an extension)
  • Breaking change (fix or feature that would cause existing functionality of an extension to change)
  • Documentation update (changes made to an existing piece of documentation)

Checklist:

  • My code adheres to the syntax used by this extension.
  • My pull request requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the Camunda Community Hub documentation.
  • I have read the Pull Request Process documentation.
  • I have added or suggested tests to cover my changes suggested in this pull request.
  • All new and existing CI/CD tests passed.
  • I will /assign myself this issue, and add the relevant [issue labels] to it if they are not automatically generated by Probot.
  • I will tag @camunda-community-hub/devrel in a new comment on this issue if 30 days have passed since my pull request was opened and I have not received a response from the extension's maintainer.

@jonathanlukas jonathanlukas self-assigned this Jul 7, 2023
@jonathanlukas jonathanlukas changed the title [converter/core] Bugfix: Empty error code leads to conversion error [bugfix][converter/core]: Empty error code leads to conversion error Jul 7, 2023
@github-actions
Copy link

github-actions bot commented Jul 7, 2023

Test Results

  25 files  +  25    25 suites  +25   2m 31s ⏱️ + 2m 31s
190 tests +190  190 ✔️ +190  0 💤 ±0  0 ±0 
308 runs  +308  308 ✔️ +308  0 💤 ±0  0 ±0 

Results for commit a708276. ± Comparison against base commit f79df84.

Copy link
Contributor

@ingorichtsmeier ingorichtsmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@ingorichtsmeier ingorichtsmeier merged commit c5afd6a into main Jul 10, 2023
@jonathanlukas jonathanlukas deleted the bugfix/converter/core/null-pointer-on-error branch July 10, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working component:diagram-converter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Cannot convert bpmn:error
2 participants