Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature][adapter]: Use execution listener #280

Merged
merged 16 commits into from
Jul 10, 2023
Merged

[feature][adapter]: Use execution listener #280

merged 16 commits into from
Jul 10, 2023

Conversation

jangalinski
Copy link
Contributor

@jangalinski jangalinski commented May 15, 2023 •
edited by jonathanlukas
Loading

Camunda Community Hub Pull Request Template

first implementation of #27
closes #27

Description

Additional context

Testing your changes

Types of changes

  • Bug fix (non-breaking change which fixes an existing open issue)
  • New feature (non-breaking change which adds functionality to an extension)
  • Breaking change (fix or feature that would cause existing functionality of an extension to change)
  • Documentation update (changes made to an existing piece of documentation)

Checklist:

  • My code adheres to the syntax used by this extension.
  • My pull request requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the Camunda Community Hub documentation.
  • I have read the Pull Request Process documentation.
  • I have added or suggested tests to cover my changes suggested in this pull request.
  • All new and existing CI/CD tests passed.
  • I will /assign myself this issue, and add the relevant [issue labels] to it if they are not automatically generated by Probot.
  • I will tag @camunda-community-hub/devrel in a new comment on this issue if 30 days have passed since my pull request was opened and I have not received a response from the extension's maintainer.

MartinKarsten1980 and others added 8 commits May 10, 2023 15:16
@MartinKarsten1980
Camunda Summit 2023: CamundaPlatform7DelegationWorker extended with s…
3d7f2ba 
…upport for executionListener.start and executionListener.end header fields, which will trigger calls to the specified beans, use to simulate the execution listener support of C7.
@jangalinski
prepare worker example
6261b36
@jangalinski
prepare worker example
fe117f5
@jangalinski
Merge branch 'main' into feature/27_execution_listener
9bbbde3
@MartinKarsten1980
Camunda Summit 2023: Repositioned the RuntimeException and extended i…
347bb3e 
…ts trigger to exclude situations where only one or both listeners are defined.
@jangalinski
working, reducer of result needs fixing
7960521
@jangalinski
finalize and provide tests
06896fe
@jangalinski
Merge branch 'feature/27_execution_listener' of github.com:holunda-io…
c9a7110 
…/camunda-7-to-8-migration into feature/27_execution_listener
@CLAassistant
Copy link

CLAassistant commented May 15, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@jangalinski jangalinski self-assigned this May 15, 2023
@jangalinski jangalinski mentioned this pull request May 15, 2023
Closed
@ingorichtsmeier
Copy link
Contributor

Hi @jangalinski, thank you for your contribution.

At a first glance, all looks good and ready to merge.

I will have a closer look and play around with some more examples soon.

jonathanlukas
jonathanlukas requested changes May 22, 2023
View reviewed changes
Copy link
Collaborator

@jonathanlukas jonathanlukas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR - it looks all very nice and clean.

You also did some refactoring to existing code which is quite nice!

There are some things to adjust, then we can merge this.

.gitignore Outdated Show resolved Hide resolved
...ter/src/main/java/org/camunda/community/migration/adapter/execution/SimpleVariableScope.java Show resolved Hide resolved
...c/main/java/org/camunda/community/migration/adapter/execution/ZeebeJobDelegateExecution.java Show resolved Hide resolved
...in/java/org/camunda/community/migration/adapter/worker/CamundaPlatform7DelegationWorker.java Outdated Show resolved Hide resolved
...st/java/org/camunda/community/migration/adapter/execution/ZeebeJobDelegateExecutionTest.java Outdated Show resolved Hide resolved
...ava/org/camunda/community/migration/adapter/worker/CamundaPlatform7DelegationWorkerTest.java Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
@jangalinski jangalinski mentioned this pull request Jun 30, 2023
Open
@jangalinski
Copy link
Contributor Author

@jonathanlukas finally found some time to work on your comments ... please check.

@jonathanlukas
Copy link
Collaborator

@jangalinski I appended some things to your PR... in a PR to your fork. I think we have reached our goal then

@jonathanlukas jonathanlukas mentioned this pull request Jun 30, 2023
Open
@jonathanlukas jonathanlukas changed the title Feature/27 execution listener [feature][adapter]: Use execution listener Jul 7, 2023
@jonathanlukas
Copy link
Collaborator

@jangalinski here is the PR: holunda-io#1

@jonathanlukas jonathanlukas self-requested a review July 10, 2023 04:48
jonathanlukas
jonathanlukas approved these changes Jul 10, 2023
View reviewed changes
Copy link
Collaborator

@jonathanlukas jonathanlukas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jangalinski jangalinski merged commit cd3da69 into camunda-community-hub:main Jul 10, 2023
@jangalinski jangalinski deleted the feature/27_execution_listener branch July 10, 2023 06:45
@jangalinski
Copy link
Contributor Author

lgtm - good enough for me ... merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathanlukas jonathanlukas jonathanlukas approved these changes

Assignees

@jangalinski jangalinski

Labels
component:adapter enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Idea to support execution listeners
5 participants
@jangalinski @CLAassistant @ingorichtsmeier @jonathanlukas @MartinKarsten1980