Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace single quotes with double quotes #274

Merged
merged 1 commit into from
May 16, 2023

Conversation

jonathanlukas
Copy link
Collaborator

@jonathanlukas jonathanlukas commented May 10, 2023

Description

JUEL allows the usage of single quotes for strings. They will be replaced with double quotes now

Additional context

closes #272
closes #275

Testing your changes

There is an additional expression test in place

Types of changes

  • Bug fix (non-breaking change which fixes an existing open issue)
  • New feature (non-breaking change which adds functionality to an extension)
  • Breaking change (fix or feature that would cause existing functionality of an extension to change)
  • Documentation update (changes made to an existing piece of documentation)

Checklist:

  • My code adheres to the syntax used by this extension.
  • My pull request requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the Camunda Community Hub documentation.
  • I have read the Pull Request Process documentation.
  • I have added or suggested tests to cover my changes suggested in this pull request.
  • All new and existing CI/CD tests passed.
  • I will /assign myself this issue, and add the relevant [issue labels] to it if they are not automatically generated by Probot.
  • I will tag @camunda-community-hub/devrel in a new comment on this issue if 30 days have passed since my pull request was opened and I have not received a response from the extension's maintainer.

@github-actions
Copy link

Test Results

  25 files  +  25    25 suites  +25   2m 33s ⏱️ + 2m 33s
188 tests +188  188 ✔️ +188  0 💤 ±0  0 ±0 
306 runs  +306  306 ✔️ +306  0 💤 ±0  0 ±0 

Results for commit 7f6b59d. ± Comparison against base commit f11415a.

Copy link
Contributor

@ingorichtsmeier ingorichtsmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@ingorichtsmeier ingorichtsmeier merged commit 269aec0 into main May 16, 2023
@ingorichtsmeier ingorichtsmeier deleted the feature/converter/replace-single-tics branch May 16, 2023 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants