Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed a bug where an errorCode is not transformed #273

Merged
merged 2 commits into from
May 16, 2023

Conversation

jonathanlukas
Copy link
Collaborator

Description

Since 0.6, this was broken. Now it works (and is tested)

Additional context

.

Testing your changes

One new unit test asserts the presence of an error code after the conversion

Types of changes

  • Bug fix (non-breaking change which fixes an existing open issue)
  • New feature (non-breaking change which adds functionality to an extension)
  • Breaking change (fix or feature that would cause existing functionality of an extension to change)
  • Documentation update (changes made to an existing piece of documentation)

Checklist:

  • My code adheres to the syntax used by this extension.
  • My pull request requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the Camunda Community Hub documentation.
  • I have read the Pull Request Process documentation.
  • I have added or suggested tests to cover my changes suggested in this pull request.
  • All new and existing CI/CD tests passed.
  • I will /assign myself this issue, and add the relevant [issue labels] to it if they are not automatically generated by Probot.
  • I will tag @camunda-community-hub/devrel in a new comment on this issue if 30 days have passed since my pull request was opened and I have not received a response from the extension's maintainer.

@github-actions
Copy link

github-actions bot commented May 10, 2023

Test Results

  25 files  +  25    25 suites  +25   2m 15s ⏱️ + 2m 15s
189 tests +189  189 ✔️ +189  0 💤 ±0  0 ±0 
307 runs  +307  307 ✔️ +307  0 💤 ±0  0 ±0 

Results for commit 45be050. ± Comparison against base commit f11415a.

♻️ This comment has been updated with latest results.

@ingorichtsmeier ingorichtsmeier merged commit 26964a4 into main May 16, 2023
@ingorichtsmeier ingorichtsmeier deleted the bugfix/error-code-removed branch May 16, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants