Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test diagrame first scope #228

Merged
merged 37 commits into from
Mar 17, 2023
Merged

Test diagrame first scope #228

merged 37 commits into from
Mar 17, 2023

Conversation

pierre-yves-monnet
Copy link
Contributor

Camunda Community Hub Pull Request Template

Test game for the migration
Different test game + automaton API to creates data in a C7 engine, ready to be migrate

Description

Differentes test games, to cover all main use case to migrate a C7 server to a C8 server.
Each test game contains

  • a description
  • the BPMN process
  • an Automator-process scenario, to produce process instances in the expected activity

Additional context

Testing your changes

Types of changes

  • Bug fix (non-breaking change which fixes an existing open issue)
  • New feature (non-breaking change which adds functionality to an extension)
  • Breaking change (fix or feature that would cause existing functionality of an extension to change)
  • Documentation update (changes made to an existing piece of documentation)

Checklist:

  • My code adheres to the syntax used by this extension.
  • My pull request requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the Camunda Community Hub documentation.
  • I have read the Pull Request Process documentation.
  • I have added or suggested tests to cover my changes suggested in this pull request.
  • All new and existing CI/CD tests passed.
  • I will /assign myself this issue, and add the relevant [issue labels] to it if they are not automatically generated by Probot.
  • I will tag @camunda-community-hub/devrel in a new comment on this issue if 30 days have passed since my pull request was opened and I have not received a response from the extension's maintainer.

pierre-yves-monnet and others added 26 commits February 21, 2023 17:17
@pierre-yves-monnet
Simple user task
d3596fc
@pierre-yves-monnet
Timer event test
8c0c0cc
@pierre-yves-monnet
Remove timer boundary event
5326852
@pierre-yves-monnet
Simple Service Task
c539d30
@pierre-yves-monnet
Review process
e121819
@pierre-yves-monnet
First release
210cb78
@pierre-yves-monnet
First release Receive task
27dda49
@pierre-yves-monnet
Rename
63ac5b2
@pierre-yves-monnet
First relase Receive Event
dc80df7
@pierre-yves-monnet
First relase Call Activity
934e5dd
@pierre-yves-monnet
First relase Call Activity 2
4845d0e
@pierre-yves-monnet
First relase Call Activity - simplify the scenario
635c64e
@pierre-yves-monnet
First relase Conditional event
90bbcbf
@pierre-yves-monnet
reformat
ab04a41
@pierre-yves-monnet
First release multi instances call activity
499826f
@ingorichtsmeier
Change input mapping to a "real" expression
8f84d67
@pierre-yves-monnet
Debugging timer scenario
c7b5c8f
@pierre-yves-monnet
Multi instance call activity
49b3744
@pierre-yves-monnet
Complex Call Activity
b07effa
@pierre-yves-monnet
Merging inclusive Activity
9f4d8a0
@pierre-yves-monnet
Merging Parallel Activity
706166a
@pierre-yves-monnet
Move timer to 1 D
a26b145
@pierre-yves-monnet
Variables test case
6d1b125
@pierre-yves-monnet
Multin instance user task
5e66511
@pierre-yves-monnet
Multin instance service task
4768711
@pierre-yves-monnet
Multi instance service task
34dd2fe
jonathanlukas
jonathanlukas requested changes Mar 8, 2023
View reviewed changes
Copy link
Collaborator

@jonathanlukas jonathanlukas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some things to change (mostly headers that are wrong)

test-example-diagrams/src/main/resources/merging-inclusive/MergingInclusive.md
@@ -0,0 +1,28 @@
# Merging Inclusive
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the diagram, the title should be Merging Parallel?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this is an Inclusive gateway here in the diagram ( ? )
image

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I just looked at the png, and there is a parallel gateway on merging:

image

...xample-diagrams/src/main/resources/multiinstances-callactivity/MultiInstancesCallActivity.md Outdated Show resolved Hide resolved
...example-diagrams/src/main/resources/multiinstances-service-task/MultiInstancesServiceTask.md Outdated Show resolved Hide resolved
test-example-diagrams/src/main/resources/multinstances-usertask/MultiInstancesUserTask.md Outdated Show resolved Hide resolved
test-example-diagrams/src/main/resources/simple-service-task/SimpleServiceTask.md Outdated Show resolved Hide resolved
test-example-diagrams/src/main/resources/timer-event/TimerEvent.md Outdated Show resolved Hide resolved
test-example-diagrams/src/main/resources/variables/Variables.md Outdated Show resolved Hide resolved
...xample-diagrams/src/main/resources/multiinstances-callactivity/MultiInstancesCallActivity.md Outdated Show resolved Hide resolved
@jonathanlukas jonathanlukas self-requested a review March 10, 2023 08:08
jonathanlukas
jonathanlukas requested changes Mar 10, 2023
View reviewed changes
Copy link
Collaborator

@jonathanlukas jonathanlukas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The png in merging inclusive needs to be renewed

@pierre-yves-monnet pierre-yves-monnet merged commit df025ae into main Mar 17, 2023
@pierre-yves-monnet pierre-yves-monnet deleted the test_diagrame_first_scope branch March 17, 2023 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathanlukas jonathanlukas jonathanlukas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pierre-yves-monnet @jonathanlukas @ingorichtsmeier