Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[converter/core] feature: Prepare Camunda 8.2 #170

Merged
merged 17 commits into from
May 5, 2023

Conversation

jonathanlukas
Copy link
Collaborator

@jonathanlukas jonathanlukas commented Jan 25, 2023

Description

As Camunda 8.2 will cover more BPMN elements, we need to adjust our ruleset to fit the progress.

This PR will cover the following changes:

  • Support Task
  • Support Escalation
  • Support Error Codes as expressions
  • Support Link Events
  • Support embedded feel scripts in Script Tasks
  • Support Signal Start Events

Additional context

Closes #166

Testing your changes

Every change is tested in 2 ways: Old version behaviour, new version behaviour.

Types of changes

  • Bug fix (non-breaking change which fixes an existing open issue)
  • New feature (non-breaking change which adds functionality to an extension)
  • Breaking change (fix or feature that would cause existing functionality of an extension to change)
  • Documentation update (changes made to an existing piece of documentation)

Checklist:

  • My code adheres to the syntax used by this extension.
  • My pull request requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the Camunda Community Hub documentation.
  • I have read the Pull Request Process documentation.
  • I have added or suggested tests to cover my changes suggested in this pull request.
  • All new and existing CI/CD tests passed.
  • I will /assign myself this issue, and add the relevant [issue labels] to it if they are not automatically generated by Probot.
  • I will tag @camunda-community-hub/devrel in a new comment on this issue if 30 days have passed since my pull request was opened and I have not received a response from the extension's maintainer.

@jonathanlukas jonathanlukas changed the title Feature/converter/core/prepare 8.2 [wip][converter/core] Featrue: Prepare Camunda 8.2 Jan 25, 2023
@jonathanlukas jonathanlukas changed the title [wip][converter/core] Featrue: Prepare Camunda 8.2 [wip][converter/core] feature: Prepare Camunda 8.2 Jan 25, 2023
@jonathanlukas jonathanlukas force-pushed the feature/converter/core/prepare-8.2 branch 6 times, most recently from 0a775ff to 3377804 Compare February 6, 2023 06:01
@jonathanlukas jonathanlukas force-pushed the feature/converter/core/prepare-8.2 branch 7 times, most recently from 8166f3d to 95577f1 Compare March 6, 2023 07:00
@jonathanlukas
Copy link
Collaborator Author

@ingorichtsmeier @shaarmann It's time for a review!

@jonathanlukas jonathanlukas changed the title [wip][converter/core] feature: Prepare Camunda 8.2 [converter/core] feature: Prepare Camunda 8.2 Apr 11, 2023
@jonathanlukas jonathanlukas force-pushed the feature/converter/core/prepare-8.2 branch 2 times, most recently from 39cfe90 to d91acfd Compare April 19, 2023 12:26
@github-actions
Copy link

github-actions bot commented Apr 19, 2023

Test Results

  25 files  +  25    25 suites  +25   2m 26s ⏱️ + 2m 26s
188 tests +188  188 ✔️ +188  0 💤 ±0  0 ±0 
304 runs  +304  304 ✔️ +304  0 💤 ±0  0 ±0 

Results for commit 6614af6. ± Comparison against base commit 67f6b7a.

♻️ This comment has been updated with latest results.

@jonathanlukas jonathanlukas force-pushed the feature/converter/core/prepare-8.2 branch 2 times, most recently from 35ce381 to f6d4d85 Compare April 24, 2023 05:48
@jonathanlukas jonathanlukas force-pushed the feature/converter/core/prepare-8.2 branch from f6d4d85 to b5947de Compare April 27, 2023 13:53
@jonathanlukas jonathanlukas force-pushed the feature/converter/core/prepare-8.2 branch from e4a5530 to 552f9f9 Compare May 5, 2023 10:58
@jonathanlukas jonathanlukas merged commit 336c463 into main May 5, 2023
@jonathanlukas jonathanlukas deleted the feature/converter/core/prepare-8.2 branch May 5, 2023 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Task: Prepare conversion rules for 8.2 release
2 participants