Skip to content

Fix request events (.on()) #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
larvanitis wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Fix request events (.on()) #17

larvanitis wants to merge 6 commits into from

Conversation

@larvanitis
Copy link

@larvanitis larvanitis commented Feb 27, 2017 •
edited
Loading

  • Don't use custom Emitter anymore.
  • Fix on method which wasn't working.
  • Rename custom event to requestCreated so that it doesn't collide with upstream's request event.

Fixes #13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@larvanitis