Replace if cfg!(kani) by #[cfg(kani)]
#148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In previous version of rustc, they would have similar behavior even in debug mode, where all the logic from a `false` evaluation would be pruned. This is no longer true in the current rustc release candidate.
4 tasks
zhassan-aws
reviewed
May 15, 2023
| @@ -28,20 +28,18 @@ pub struct TargetLocation { | |||
|
|
|||
| impl TargetLocation { | |||
| pub fn should_run(&self) -> bool { | |||
There was a problem hiding this comment.
Might be cleaner to duplicate this function instead since there is no common code between kani and not(kani)?
| @@ -65,59 +63,71 @@ impl TargetLocation { | |||
| } | |||
|
|
|||
| pub fn abs_path(&self) -> Option<PathBuf> { | |||
camshaft
approved these changes
May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In previous version of rustc, they would have similar behavior even in debug mode, where all the logic from a
falseevaluation would be pruned.This is no longer true in the current rustc release candidate. I created this thread to see if this was by design or if it's a bug.
That said, this is currently blocking the Kani toolchain upgrade PR, so I was hoping we could switch the definition. Thanks!